Box-model rule now honors box-sizing on the universal selector#797
Open
patrickkettner wants to merge 1 commit into
Open
Box-model rule now honors box-sizing on the universal selector#797patrickkettner wants to merge 1 commit into
patrickkettner wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the universal selector declares
box-sizing(e.g.* { box-sizing: border-box; }, or the common*, *:before, *:aftergroup), the box-model rule no longer warns about width or height used with padding or border, since the declaration applies to all elements.To make this work regardless of where the universal rule appears in the stylesheet, warnings are collected during parsing and reported on
endstylesheet(the same pattern the overqualified-elements rule uses). Qualified or scoped universal selectors (*.foo,div *) do not suppress the warnings.dist/is intentionally not rebuilt to keep the diff reviewable (a fresh build also stamps the current year into the banner and regenerates bundled parserlib whitespace unrelated to this change). Happy to regenerate it if preferred.Fixes #243