Repository navigation
INFO: back off compat to 1.2.29 - #54
Closed
TheWitness wants to merge 1 commit into
Closed
TheWitness wants to merge 1 commit into
TheWitness wants to merge 1 commit into
Conversation
TheWitness
requested review from
bmfmancini,
browniebraun,
cigamit and
xmacan
and
a balanced review from Copilot
September 30, 2026 14:52
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The compatibility change must be documented in the changelog.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Lowers the plugin’s minimum Cacti compatibility from 1.2.32 to 1.2.29.
Changes:
- Updates the compatibility floor in plugin metadata.
| File | Description |
|---|---|
INFO |
Sets minimum Cacti version to 1.2.29. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
No longer required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backs off the INFO minimum Cacti compat from 1.2.32 → 1.2.29, per developer feedback on the compat rollout.
Unique-key assessment
This plugin is not affected by the Cacti 1.2.29–1.2.31
db_update_table()unique-key drop: its schema usesapi_plugin_db_table_create()and defines no unique keys viaunique_keys, so no re-introduction helper is required.Show-stoppers
None identified beyond the version-floor change itself.