Fix fatal redeclare from leftover legacy include/ directory

[TheWitness]

Problem

On installs upgraded from the old layout, the plugin fatals and Cacti auto-disables it:

ERROR PHP COMPILE_ERROR in Plugin 'intropage': Cannot redeclare intropage_get_allowed_devices()
(previously declared in .../plugins/intropage/include/functions.php:34)
in file: .../plugins/intropage/includes/functions.php on line: 47

The library directory moved from include/ to includes/. After an upgrade, the old include/ directory lingers on disk and stale plugin_hooks rows still point at include/<file>. When a stale hook (e.g. graph_buttons) fires, Cacti loads include/functions.php; the plugin's own code then loads includes/functions.php, redeclaring every shared function → fatal.

The existing repoint + prune logic lives inside intropage_upgrade_database(), which runs from display_information() / the config-check hook — too late: the stale hook fires earlier in the same request, and once Cacti disables the plugin the migration never runs again, so the install is permanently stuck.

Fix

Add intropage_cleanup_legacy_include() and call it at the top of intropage_config_arrays() — the earliest per-page hook, always registered from setup.php (a file that was never under include/, so its hook row is never stale). Before any stale graph_buttons/console_after hook can load the old library, it:

1. Repoints any remaining plugin_hooks row from include/ to includes/ (fixes future requests), and
2. Physically removes the leftover include/ directory (so a hook target cached for the current request can no longer load a second copy of the library).

It early-returns when include/ is absent, so it's a cheap is_dir() no-op on healthy installs. Reuses the existing plugin_intropage_rmtree() helper and logs a warning if removal is blocked by permissions.

Testing

• php -l setup.php passes.

[Copilot]

Copilot review overview

🟡 Changes recommended

Cleanup can miss stale hooks and follow a symlink outside the plugin directory, and the recovery behavior lacks tests.

Review effort: Balanced
Findings: 1

Open (1)

• Repair stale hook rows before the early filesystem return · New

What changed in this PR

Adds early cleanup for legacy include/ installations to prevent fatal function redeclarations.

Changes:

• Repoints stale plugin hook paths.
• Removes the legacy directory before later hooks execute.
• Documents the fix in the changelog.

File	Description
setup.php	Adds and invokes legacy-directory cleanup.
CHANGELOG.md	Records the upgrade fix.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.