Repository navigation
Defer billboard (.bb) styling to the Cacti theme - #418
Merged
Merged
Conversation
css/midwinter.css carried billboard .bb axis/legend/arc rules. Those now live in the midwinter theme's main.css (present on the AJAX overload path where billboard.css is not), so remove them here. Non-billboard intropage rules are kept.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Supported older Cacti versions lack the paired core styling, causing a visual regression.
Review effort: Balanced
Findings: 1
What changed in this PR
Removes plugin-owned Billboard.js styling in favor of Cacti theme styling.
Changes:
- Deletes Midwinter
.bb*rules while preserving plugin-specific styles.
| File | Description |
|---|---|
css/midwinter.css |
Removes Billboard.js theme overrides. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
xmacan
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
css/midwinter.csscarried billboard.js (.bb*) axis/legend/arc rules. Billboard styling belongs to the Cacti theme, not the plugin.Those rules now live in the midwinter theme's
main.css(which is present on the AJAX overload path where the theme'sbillboard.cssis not loaded), so the look is preserved while the plugin no longer ships its own billboard styling.Change
.bb-axis-*,.bb-legend-item,.bb-axis, and.bb-chart-arcrules fromcss/midwinter.css..grid_item,.panel_data,.header_link,circle,.txt_*, …).Paired with the Cacti core change that adds the matching
.bbrules toinclude/themes/midwinter/main.css. No functional/data changes.