ci: drop inert COMPOSER_ROOT_VERSION from the Pest step - #837
Merged
Merged
Conversation
TheWitness
requested review from
bmfmancini,
browniebraun,
cigamit and
xmacan
and
a balanced review from Copilot
September 29, 2026 18:37
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused cleanup is correct and does not alter test execution behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Removes an unused Composer environment variable from the Pest test step.
Changes:
- Deletes the inert
COMPOSER_ROOT_VERSIONsetting from the test execution step.
| File | Description |
|---|---|
.github/workflows/plugin-ci-workflow.yml |
Simplifies the Pest CI step by removing unused configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
COMPOSER_ROOT_VERSION only influences Composer root-version detection, which does not run in the "Run Pest Unit Tests" step (Composer install happens in an earlier step). Removing it from that step's env; no behaviour change. Part of harmonizing the patch-coverage CI convention across the plugin fleet.
TheWitness
force-pushed
the
ci/enforce-patch-coverage
branch
from
September 29, 2026 18:55
d403a34 to
24e37ef
Compare
xmacan
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
COMPOSER_ROOT_VERSION: 1.3.0-devfrom the Run Pest Unit Testsstep's
env:.Why
COMPOSER_ROOT_VERSIONonly affects Composer's root-package versiondetection, which runs during
composer install— an earlier step — notduring the Pest run. In the Pest step it is inert, so it is being removed.
This is a small consistency cleanup alongside harmonizing the patch-coverage
CI convention across the plugin fleet (this repo is already the reference
implementation for the
Enforce coverage of changed linesgate).