Repository navigation
Use a CSS class for the status legend footer instead of inline styles - #850
Open
TheWitness wants to merge 2 commits into
Open
TheWitness wants to merge 2 commits into
TheWitness wants to merge 2 commits into
Conversation
Wrap the thold, host and log legend renders in the same fixed-position footer container MacTrack uses, so the legend stays pinned to the bottom of the viewport instead of scrolling away with the list.
TheWitness
requested review from
bmfmancini and
xmacan
and
a balanced review from Copilot
October 7, 2026 20:07
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The fixed legends can obscure final page content because their responsive height is not reserved in the document flow.
3 open findings
What changed in this PR
Pins threshold, device, and log status legends to the viewport bottom.
Changes:
- Wraps four legends in fixed-position footer containers.
- Mirrors MacTrack’s legend positioning.
| File | Description |
|---|---|
thold.php |
Pins the threshold legend. |
thold_graph.php |
Pins threshold, device, and log legends. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cigamit
previously approved these changes
Oct 7, 2026
Replace the inline fixed-position wrapper around the status legend with a plugin-specific *LegendFooter class defined in the plugin's stylesheet. The class lays the legend out as a centered footer in normal document flow, so it no longer sits outside flow and overlay the final rows, pagination, or action controls at the bottom of the page.
TheWitness
changed the title
bmfmancini
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Originally each status legend was wrapped in an inline-styled, fixed-position container copied from MacTrack:
Per review, the inline style is replaced with a dedicated
.tholdLegendFooterCSS class, and it now lays the legend out as a centered footer in normal document flow rather thanposition: fixed. Staying in flow means it reserves its own space and no longer overlays the final rows or the action dropdown/Go button — resolving the reviewer's overlay findings. MacTrack and the other legend plugins (Monitor/Servcheck/Syslog) are being updated the same way.How
.tholdLegendFooterto everycss/<theme>.css(Thold loads one theme stylesheet per page, each of which already defines.tholdLegend).thold.phpandthold_graph.phpfor<div class="center tholdLegendFooter">.No change to the legend chip markup/styles themselves.
Types of changes
Checklist
php -lclean on the changed files.