Repository navigation
Conversation
Cache deterministic outcomes with safe response headers and a bounded UTF-8 body. Keep reconciliation responses retryable. Repair full lint/type contracts and preserve SQLite quota rollback. Published 0026 collisions remain blocked on deployment history; do not rename applied artifacts or bypass migration policy. Refs CalloraOrg#1499
|
@stmr Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Keep the cache retry transition regression aligned with the current public ErrorEnvelope contract. Preserve all retry, replay and deduction-count assertions.
|
Fixed the reachable author-side full-suite regression in eb3fd3f: the test now reads the current documented Full original Linux workflow on the exact source/tree: build-and-test passed (full lint/type/build,175 suites/2629 tests/1 snapshot,2 existing skipped tests, Vercel bundle), and OpenAPI compatibility passed. The only remaining repair prerequisite is the published-migration deployment-history clarification, needed to avoid replaying a financial backfill or invalidating applied artifacts. No CI-setting change or weakened check is requested. Keeping this draft until the data-safe migration resolution is possible. No merge, deployment, points or payment claimed. |
Merge accepted upstream main while preserving lease ownership, fencing, renewal and response completion. Apply transient-response cache policy, bounded encoded-body inspection and safe header replay. Enforce billing payer ownership and duplicate-request isolation, restore canonical error envelopes, repair source contracts and stable history ETags, and restore seven repaired suites to default CI. Keep every accepted historical SQL file byte-identical. Only the unapplied response-header migration moves to the unused 0028 prefix. Historical migration-policy violations remain explicit and unresolved. Refs CalloraOrg#1499
Merge accepted upstream main while preserving lease ownership, fencing, renewal and response completion. Apply transient-response cache policy, bounded encoded-body inspection and safe header replay. Enforce billing payer ownership and duplicate-request isolation, restore canonical error envelopes, repair source contracts and stable history ETags, and restore seven repaired suites to default CI. Keep every accepted historical SQL file byte-identical. Only the unapplied response-header migration moves to the unused 0028 prefix. Historical migration-policy violations remain explicit and unresolved. Refs CalloraOrg#1499
Preserve accepted lease fencing while integrating current main. Lock quotes before expiry checks; verify on-chain payment and match the actual signed envelope fee before committing consumption. Keep published migration history unchanged. Migration policy remains blocked pending deployed-history confirmation. BREAKING CHANGE: fee execution requires quoteId and a quote-bound memo. Refs CalloraOrg#1499
The published API-created head has the same complete tree as an already integrated local ancestor. Join its ancestry without changing the verified integration tree; no published changes are discarded.
|
Integrated accepted main Exact-tree Linux run: build-and-test passed (lint, full types, 191 suites / 2,844 tests, Vercel HTTP smoke); OpenAPI compatibility passed. Two pre-existing skips remain. Overall CI is not green: migration-policy still reports ten published-history/layout violations. No historical SQL was edited or renumbered; the existing deployed-history question remains the prerequisite for a data-safe repair. Payment signing now verifies quote-bound on-chain payment and consumes it atomically. Native PostgreSQL reproduced an expiry-after-lock-wait bug; explicit row locking fixes it. Four deterministic multi-backend races passed, plus real compiled HTTP/SDK signing with two blocked native backends and exactly one cryptographically verified envelope. Synthetic chain transport only; no real funds. The API requires quoteId and the quote MEMO_HASH, documented in The temporary author-side validation PR was closed unmerged. Keeping this PR draft; not claiming deployment readiness, points or payment. |
|
This PR is still marked as a draft, so it can't be reviewed or merged yet. When it's ready, please rebase onto the latest default branch, make sure CI passes, and click Ready for review. Note: PRs that change |
Preserve atomic fee payment verification and idempotency behavior. Accepted main layout changes do not establish deployed filename or checksum history; deployment remains gated on maintainer confirmation.
Record each refund grant atomically with its balance change. Ledger SQLite migrations without rewriting existing records. Integrate accepted main without replaying published backfills. Keep populated quote and receipt rollbacks fail-closed. Refs CalloraOrg#1499
Propagate billing cancellation through payment verification and quote consumption. Check after database waits before signing so cancelled requests roll back and can retry with the same payment. Keep verification budgets below enabled billing deadlines.
Scope
Closes #1499. Integrated accepted upstream main
5b7a197214b976dfa0cf90d014220962a4e378bcwithout force-pushing. No main ref changed in this update.API contract: fee execution requires
quoteId, unchanged inner XDR and a64-hex payment transaction hash carrying the quote MEMO_HASH. Seedocs/fee-abstraction.md.Published source and exercised proof
Head
51b33d72eb6d1913da120ade0c951ebf7e8cd987; treec537ae3c05f40e4c2845ca827d51f2c5f9ff0e21.tests/integration/feeAbstraction.postgres.mjs. Its signer callback is synthetic.Current exact-tree author CI — NOT all green
Run40230593334 uses the approved CI-only
developbaseline at accepted upstream5b7a197. The author-fork main remains frozen at22fd831. The unchanged workflow already supports develop; no checker rule, skip or permission was changed.CI synthetic merge
542c4e188d234a6854609104fbd99af2ff4c2f91has treec537ae3c05f40e4c2845ca827d51f2c5f9ff0e21, exactly the reviewed source tree.build-and-test: SUCCESS (full lint/types/build/tests and Vercel smoke).migration-policy: SUCCESS.openapi-compat: FAILURE,537/626 checks pass. The89 remaining reports all concern adding the sameIDEMPOTENCY_KEY_REUSE_MISMATCHresponse-enum option. Incoming-main DEMO/billing-schema differences from the older22fd831 baseline are no longer the issue.The author CI PR is technical validation only, OPEN/DRAFT and must not be merged.
Maintainer catalog decision needed
Accepted main already emits
IDEMPOTENCY_KEY_REUSE_MISMATCHdirectly from idempotency middleware, and its tests/docs rely on that value, but omitted it from the authoritative generated catalog. This PR catalogs that existing code so the new durable-receipt mismatch path remains consistent after HTTP-cache eviction. I have kept the documented code rather than introducing a receipt-only generic CONFLICT split.Please confirm acceptance of cataloging this already-emitted code and the project's proper canonical catalog/compatibility process needed to clear the gate. No ignore rules, skipped checks or fabricated approval have been added; the compatibility failure is intentionally reported, not waived.
Review / deployment gate
Keeping this PR draft while that contract gate is unresolved. Accepted numbering does not prove the real deployed PostgreSQL filenames, versions, checksums or financial-backfill execution history. The existing deployment-history question remains unanswered. No aliases, historical ledger rewrites, blind replay, deployment-readiness, merge approval, points or payment are claimed.