Repository navigation
feat(billing): submit vault deduct via stellar-sdk with u64 request ids - #1555
Open
esegbueadam-sys wants to merge 1 commit into
Open
esegbueadam-sys wants to merge 1 commit into
esegbueadam-sys wants to merge 1 commit into
Conversation
- Replace simulate-only Soroban RPC client with SorobanVaultBillingClient that builds, signs, submits and confirms real vault.deduct(caller, amount, request_id) transactions using @stellar/stellar-sdk - Add deterministic u64 onchain_request_id from Postgres sequence (never 0, reused across retries for idempotency) - Map VaultError contract codes to stable SorobanRpcError categories (InsufficientBalance→INSUFFICIENT_BALANCE, Paused/Unauthorized/ExceedsMaxDeduct→CONTRACT_ERROR) - Wire createSorobanBillingService to new client; missing SOROBAN_BILLING_BACKEND_SECRET_KEY logs warning and returns undefined (no partial client) - Update docs: billing-deduct.md request_id mapping, fee-abstraction.md, soroban-simulation-diagnostics.md error codes, .env.example with testnet values - Add onchain_request_id column + sequence migration 0033 - Reorder app.ts dependencies: vaultRepository resolved before billing service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1487