Repository navigation
fix(ci): repair main type-check and finish per-API rate limit wiring - #1365
Merged
Merged
Conversation
#1356 was squashed with only part of its changes, leaving main failing type-check: App.tsx used useToast/Navigate without importing them and referenced APP_ROUTES.legacyRateLimit, and RateLimitCard referenced an undefined `api`. Its test file was a broken merge of old and new tests. - App: import Navigate and useToast, route /marketplace/:apiId/rate-limits to RateLimitCard and redirect legacy /rate-limit to the Marketplace with a one-time toast. - RateLimitCard: resolve the API from fetchCatalog by :apiId, build the table/cards from api.rateLimits, hide empty optional columns, and handle loading, not-published, not-found and error states. - renderRoute: use isMarketplaceSubpage so per-API subpages reach App. - ApiDetailPage: add a "View rate limits" link next to "View SLA". - Tests: rewrite RateLimitCard tests, point route-splitting test at the per-API path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main has been red since 2026-10-21. The latest failure is
tsc --noEmitinsrc/App.tsxandsrc/pages/RateLimitCard.tsx, because #1356 was merged with only part of its changes.Changes
src/App.tsx: importNavigateanduseToast; addlegacyRateLimit: "/rate-limit"and moverateLimitCardto/marketplace/:apiId/rate-limits. The legacy redirect shows its toast once, even under StrictMode.src/pages/RateLimitCard.tsx: per-API page driven byfetchCatalogandapi.rateLimits, with loading, not-published, not-found and error states, and optional columns.src/renderRoute.tsx: useisMarketplaceSubpageso/marketplace/:id/rate-limitsreachesApp.src/pages/ApiDetailPage.tsx: add a "View rate limits" link.RateLimitCard.test.tsx(the old file was a broken merge) and updateRouteSplitting.test.tsx.Follow-up commits on this PR fix whatever later CI steps (build, vitest) turn up.
🤖 Generated with Claude Code