Skip to content

feat: expand desktop editing, Studio Sound, and camera effects - #2290

Merged
richiemcilroy merged 117 commits into
mainfrom
codex/desktop-editor-camera-audio
Sep 13, 2026
Merged

richiemcilroy merged 117 commits into
mainfrom
codex/desktop-editor-camera-audio

Conversation

@richiemcilroy

@richiemcilroy richiemcilroy commented Sep 13, 2026

Copy link
Copy Markdown
Member

Expand the desktop editor across Tauri and GPUI with richer clip, text, 3D camera, audio, and export controls. Improve recording startup, camera previews, and thumbnail refresh so the recorded and edited state stays consistent across both apps.

Changes

  • Upgrade Studio Sound to bundled RNNoise with configurable isolation, voice profiling, level normalization, progressive caching, and processing off the audio callback. Apply clip volume and enhancement consistently to playback and export.
  • Add camera background removal and improved blur, preserve transparent cutouts through preview and rendering, and retain camera placement when recordings open in the editor.
  • Add clip merging, names, volume, and cursor visibility; richer text styles and animations; 3D shot controls, timeline previews, and automatic scenes in both editors.
  • Add sampled export estimates, resource guards, decoder reuse, and refreshed export and crop interfaces.
  • Improve countdown sound ordering, picker readiness, device startup, deferred recovery, recent-media loading, recording sounds, and edited thumbnail invalidation.
  • Add audio, camera, export, and editor regression coverage, diagnostic probes, and performance harnesses. Keep project compatibility and generated bindings alongside their source changes.

Validation

  • Desktop Vitest: 57 files, 526 tests passed.
  • Shared Rust library tests: 286 passed, 4 ignored across audio, project, utilities, and RNNoise.
  • Affected Rust crates: Clippy passed with all targets and warnings denied. Camera placement regression tests: 8 passed, 1 benchmark ignored.
  • Camera effects: 22 unit tests passed, plus the GPU/ONNX blur and cutout test passed explicitly.
  • Editor audio and playback: 46 regression tests passed; cursor-only export: 2 tests passed.
  • Synthetic 30-second native editor playback/export self-test passed with 935 frames presented and A/V sync within its tolerance.
  • Desktop TypeScript and scoped Biome checks passed.
  • Root and GPUI Rust formatting checks passed.
  • Cargo checks passed for the affected workspace crates and the GPUI desktop using its newer toolchain.

Greptile has reached 5/5 on the final head with all actionable threads resolved. RNNoise lifecycle and non-silent inference tests pass on Linux, Windows, and macOS. Linux audio/playback CI passed at 7f00b8053; the audio, editor, and RNNoise sources are unchanged at the final head. GPUI clip/edit tests passed (73 tests), and the queue-recovery tests passed (6 tests), with production timeouts preserved. Longer cross-platform build and integration jobs remain in progress. These source and automated checks do not establish complete native interaction, playback, or export coverage for every new UI flow. No database migration or new environment variable is required.

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the previous findings are resolved and the latest changes introduce no actionable regressions.

Summary

  • Bundles RNNoise and adds progressive Studio Sound processing with playback/export integration.
  • Adds background removal, blur improvements, transparent camera composition, and camera-placement persistence.
  • Extends timeline editing, 3D scenes, text styling, clip controls, export estimates, and resource guards.
  • Improves recording startup, recovery, picker readiness, sounds, and thumbnail invalidation.
  • Since the previous review, renames the 3D panel to satisfy filename conventions, removes narrative comments, and makes the segmented-frame timing test less scheduler-sensitive without changing production behavior.

Reviews (4) · Last reviewed commit: "test(recording): tolerate runner delays ..."

@richiemcilroy

Copy link
Copy Markdown
Member Author

hey @greptileai, please re-review the PR

Comment thread apps/desktop-gpui/src/editor_clips.rs
@richiemcilroy

Copy link
Copy Markdown
Member Author

hey @greptileai, please re-review the PR

Comment thread apps/desktop/src/routes/editor/three-d-panel.tsx
@richiemcilroy

Copy link
Copy Markdown
Member Author

hey @greptileai, please re-review the PR

Comment thread apps/desktop/src/routes/editor/ThreeDPanel.tsx Outdated
@richiemcilroy

Copy link
Copy Markdown
Member Author

hey @greptileai, please re-review the PR

@richiemcilroy
richiemcilroy merged commit 6a9f6c1 into main Sep 13, 2026
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant