Fix migration completion checks - #201
Merged
nullure merged 1 commit intoAug 13, 2026
Merged
Conversation
nullure
marked this pull request as ready for review
August 13, 2026 13:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
user_idfor 1.2.0 andproject_idfor 1.3.0).schema_versionclaims the migration already ran, so databases incorrectly marked as 1.3.0 can self-repair.Why
The migration runner used
memories.user_idas the applied check for every migration. Once 1.2.0 added that column, 1.3.0 was skipped and the missingproject_idcolumns were still recorded as applied.The version record alone cannot repair databases that already hit this bug, so the runner now also checks the migration-specific completion column.
Impact
Existing databases marked as 1.3.0 but missing project isolation columns are repaired on the next migration run. Already-correct databases remain unchanged.
Validation
npm run typechecknpx vitest run tests/migrate.test.ts --maxWorkers=1 --no-file-parallelismnpm test(42 tests passed)Closes #196