Skip to content

[ENG-12627] Make Django admin login page use custom LoginView to enfore 2FA #11999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adlius wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[ENG-12627] Make Django admin login page use custom LoginView to enfore 2FA #11999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions admin/base/urls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,13 @@
from django.contrib import admin
from admin.base.settings import ADMIN_BASE, DEBUG
from admin.base import views
from admin.common_auth.views import LoginView

base_pattern = f'^{ADMIN_BASE}'

# Route Django admin's login through our LoginView so it enforces two-factor auth
admin.site.login = LoginView.as_view()

urlpatterns = [
### ADMIN ###
re_path(
Expand Down
5 changes: 5 additions & 0 deletions admin_tests/common_auth/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

from django.utils import timezone
from django.test import RequestFactory
from django.urls import resolve, reverse
from django.http import Http404
from admin.nodes.views import NodeSearchView
from tests.base import AdminTestCase
Expand Down Expand Up @@ -243,3 +244,7 @@ def custom_login(request, user, *args, **kwargs):
mock_redirect.assert_called()
mocked_login.assert_not_called()
assert not hasattr(request, 'user')

def test_django_admin_login_uses_login_view(self):
match = resolve(reverse('admin:login'))
assert match.func.view_class is LoginView