[NXOS] Add Multi-Site fields to ShowNveInterfaceDetail - #1002
Open
behrang-t wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhances the NX-OS
ShowNveInterfaceDetailparser to parse three Multi-Site fields that are present in the existing CLI test output but were previously ignored:Fabric convergence timeFabric convergence time leftMultisite fabric-advertise-pip l3 configuredThe parser now exposes these values as:
fabric_convergence_time(int)fabric_convergence_time_left(int)multisite_fabric_advertise_pip_l3(bool)Changes
ShowNveInterfaceDetailSchema.p27,p28andp29.golden_output4_expected.pyfixture to validate the parsed values.changelog/undistributed/.No new raw CLI fixture was required because the existing
golden_output4_output.txtalready contains all three CLI lines.Testing
golden_output4passes after the parser change.ShowNveInterfaceDetailfolder-based tests pass with a 100% success rate.python -m py_compilepasses.git diff --checkpasses.make jsonsuccessfully. The generatedgithub_parser.jsonwas not included because local generation introduced unrelated environment-specific path changes.