feat: allow compatibility with more arrow and adbc versions - #68
feat: allow compatibility with more arrow and adbc versions#68carlvoller wants to merge 1 commit into
Conversation
|
Unfortunately, Cargo is not designed to work like this. Those versions are not guaranteed to unify. With a random I wrote a little blurb explaining this for the This is also mentioned briefly in the Cargo book (see the example just before the linked section): https://doc.rust-lang.org/cargo/reference/resolver.html#version-incompatibility-hazards Part of the idea of adding the concept of public and private dependencies to Cargo was to make the resolver take this into account and avoid choosing incompatible versions, but this ends up being a very hard (like, NP-hard I think) problem to solve in the general case: rust-lang/rust#44663 (comment) Now that |
|
Hi @abonander, Yea sorry I didn't come across the blurb you wrote in It would be really helpful if you guys are open to releasing an Regardless, thank you so much for taking your time to consider this. I really appreciate it. |
Summary
Wanted to try adbc_clickhouse in two of my existing projects, and just my luck my projects are using Arrow v57 and v59, not v58 which was explicitly constrained in adbc_clickhouse's Cargo.toml. Looking through the repo, doesn't seem like anything strictly relies on Arrow v58 and adbc_core v0.23. Would be nice if the range of supported arrow versions be widened.
I believe this might require a change in https://github.com/ClickHouse/clickhouse-rs/tree/main/ext-arrow which also strictly uses Arrow v58. If you're open to this change, I'm happy to open a PR in clickhouse-rs too.
Checklist
Delete items not relevant to your PR: