Fix flaky binary_strings_round_trip - #73
Merged
Merged
Conversation
abonander
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: don't assert version-dependent server metadata in
binary_strings_round_tripProblem
CI is red on
params::binary_strings_round_tripwith a schema mismatch where the data isbyte-identical and the only difference is one metadata key: the expected schema has
"PARQUET:logical_type": "UUID"on the UUID column, but the server response doesn't.That key is incidental server metadata and varies by server version — the test baked it in
because the
clickhouse-server:latest-alpineimage emitted it when the test was written. CIuses the unpinned
latest-alpinetag, and current versions no longer emit the key, so thetest broke without any driver change.
Change
Test-only, in
tests/it/params.rs:PARQUET:logical_typeentry from the expected schema (the canonicalarrow.uuidextension keys stay).PARQUET:logical_typefrom each field's metadata, so the test passes whether or not theserver version emits that key. Everything else — data, types, nullability, and all other
metadata — is still compared strictly.
Verification
cargo fmt/clippyclean.Follow-up idea (not in this PR)
CI's unpinned
latest-alpineimage means server behavior changes land on open PRs as unrelatedfailures. Pinning a server version for PR CI (with a scheduled job tracking
latest) would keepPR runs deterministic.