Support more native datatypes in Walshadow - #92
Merged
Conversation
harshil-goel
force-pushed
the
harshil/support-data-types
branch
from
August 25, 2026 07:32
07694b8 to
62a2051
Compare
serprex
reviewed
Aug 25, 2026
serprex
reviewed
Aug 25, 2026
serprex
reviewed
Aug 25, 2026
| // Composite columns take a whole PG array/hstore text (oracle-resolved) | ||
| // and fan it into nested buffers, independent of the value's own kind. | ||
| match buf { | ||
| ColumnBuf::Array { .. } => return encode_array(buf, v), |
Member
There was a problem hiding this comment.
something seems wrong here, that we're taking oracle encoded values & then parsing them
maybe daemon protocol for oracle should be sending CH native blocks instead. extension can use pg-clickhouse-c or clickhouse-c
harshil-goel
force-pushed
the
harshil/support-data-types
branch
from
August 25, 2026 08:33
62a2051 to
11c081d
Compare
harshil-goel
force-pushed
the
harshil/support-data-types
branch
3 times, most recently
from
August 25, 2026 10:10
c685471 to
06df467
Compare
serprex
reviewed
Aug 25, 2026
| // `_<elem>` (PG array convention) → Array of a supported element, else | ||
| // the String fallback (geography stays String, rendered WKT at decode). | ||
| _ => { | ||
| if att.type_name == "hstore" { |
Member
There was a problem hiding this comment.
we might need some pg_depend/pg_extension tracking to also check type's extension info
serprex
reviewed
Aug 25, 2026
| _ => { | ||
| if att.type_name == "hstore" { | ||
| "Map(String, Nullable(String))".into() | ||
| } else if att.type_name == "vector" || att.type_name == "halfvec" { |
Member
There was a problem hiding this comment.
ideally we map to QBit, or at least halfvec to Array(BFloat16)
CH & pg disagree here: CH offers BFloat16 which is not 1:1 ieee half float
harshil-goel
force-pushed
the
harshil/support-data-types
branch
from
August 26, 2026 12:45
06df467 to
5b5bde0
Compare
serprex
reviewed
Aug 26, 2026
serprex
reviewed
Aug 26, 2026
harshil-goel
force-pushed
the
harshil/support-data-types
branch
2 times, most recently
from
August 27, 2026 09:59
9205d19 to
3c81793
Compare
serprex
reviewed
Aug 27, 2026
harshil-goel
force-pushed
the
harshil/support-data-types
branch
2 times, most recently
from
August 31, 2026 11:46
2925506 to
b93c386
Compare
harshil-goel
force-pushed
the
harshil/support-data-types
branch
from
August 31, 2026 15:27
b93c386 to
f63b3ee
Compare
serprex
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.