Tidy, move parsing from project effects scripts to parsing scripts - #57
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
=======================================
Coverage 80.95% 80.95%
=======================================
Files 3 3
Lines 84 84
=======================================
Hits 68 68
Misses 16 16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
brews
marked this pull request as ready for review
September 3, 2026 20:25
brews
added a commit
that referenced
this pull request
Sep 3, 2026
ERA5 parsing might have become a bit too unstable after #57. Persisting data to the cluster after regridding helps to stabilize workers.
brews
added a commit
that referenced
this pull request
Sep 4, 2026
Fixes a reference to old coordinate names when rechunking forecast data for QDM bias adjustment. This is leftover from #57.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/05-project_effects.pyincludes parsing and cleaning logic when it first reads the input data. This PR tidies up the script and moves this cleaning and parsing logic toscripts/01-parse_era5.py,scripts/01-parse_forecast.py, andscripts/01-parse_gmfd.py.The logic moved between scripts largely changes "latitude" to "lat", "longitude" to "lon", and shifts the 0-to-360 longitude to -180-to-180, in ascending order.
Logic in
scripts/05-project_effects.pyto detect and remove incomplete months from the end of forecasts has also been moved into its own function that runs after the forecast ensemble has been loaded into memory. This is a relatively small code cleanup and should not change the script's output.This PR is a breaking change because it changes the structure of the data output by the above parsing scripts and both bias-adjustment scripts.
Close #37