Repository navigation
feat(tickets): native Konf ticketing in admin pages, plan gate for 'konf' - #2249
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
|
Review of 02ded98: CHANGES REQUESTED Read-only adversarial review of the head commit (CI green, 22 files, no deletions, Sanity change is an added list option only; What holds
Findings
Nothing out of scope; no deletions; the |
…redentials; konf plan-gate tests
|
Review of 546df6f: APPROVE Verified each fix against 02ded98 (
Nit, non-blocking: The sessionless caller ( |
Closes #2238, closes #2247.
What
Provider
src/lib/tickets/provider/konf.ts: readsticketOrders(andticketSales.byTypefor the types page) through the Konf API as the signed-in organizer (identityJwt(), host from the request — no client conference id). Refuses before any request when there is no session.Mapping
konf-orders.ts(pure): one ticket row per seat (line quantity), cancelled orders dropped,paidfrom status, outstanding = unit price for pending. NullbuyerName→customer_name: null, empty crm name. Existing pages (stats, progression, orders, attendees, dashboard widget) consume it unchanged.VAT:
amountsIncludeVatisundefinedfor Konf (interface widened toboolean | undefined); the revenue card shows no incl./ex. label, since the platform records no VAT basis.Binding:
'konf'added toTicketingProviderType, the zod enum, the D1 read check, Sanity option list (append-only addition),EditConferenceCard, conference/activation/legal type copies. Activation checklist countskonfas bound.Access (
admin-access.ts): after the deny kill switch,konfisreadyiffisTicketingEnabledForOrg, elseunavailable. No credentials.resolveTicketingProvider/hasTicketingBindingreturn unconfigured forkonf, so webhook, speaker-ticket and public paths skip it.Native ticketing: plan gate for selling with provider 'konf' #2247:
sellsTickets(packages/tenancy and src/lib/billing, kept identical) returns true forticketingProvider: 'konf'. Choosing native ticketing is the decision to sell; there is no vendor event to bind. The existing router gates (binding change, publish) therefore requirebasicbefore a free tenant switches to or publishes akonfedition. Because services use packages/tenancy, the gateway gate applies too (no services/* code changed).services test:
services/conference/src/worker.test.tsasserted that pickingkonfalone is never gated, which is exactly what Native ticketing: plan gate for selling with provider 'konf' #2247 changes. Test updated (free refused with PLAN_REQUIRED, basic allowed). No services code changed. The original assertion failing in CI on the first push is the sabotage proof for the gateway side.Evidence
Sabotage (each removed, test failed, restored green):
resolveTicketingAdminAccessLocal: 148 files / 3805 tests green across tickets, billing, tenancy, legal, settings, server.
npx eslint .0 errors,lint:tenancyOK,tscclean.Visual: Storybook
Systems/Tickets/Admin/TicketSalesChartDisplay→NativeKonf: native orders →ticketsFromOrders→ realTicketSalesProcessor. Viewed at 1280: cards and chart render, revenue card has no VAT label. (The page itself is a server component with no story; this is the component it renders in ready state.)Gaps / follow-ups
ticketingProvider: 'konf'+ ticketing grant for kkdemo) is not built here; follow-up.ProviderUnsupportedError).konf.