Repository navigation
Conversation
Removes leftover TODO after 195fe17 and dead dayjs setup in ProxiwashListHeader. New lightweight component shows relative update time (just now / minutes / hours) with a 15s interval and localized strings, no external dependency.
ignyx
requested changes
Oct 12, 2026
ignyx
left a comment
ignyx
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR, it looks good ! I requested a minor change in the input props.
| import i18n from 'i18n-js'; | ||
|
|
||
| type Props = { | ||
| date: Date | string | number; |
Contributor
There was a problem hiding this comment.
Force the date to always be a Date
| return () => clearInterval(id); | ||
| }, [intervalMs, time]); | ||
|
|
||
| if (Number.isNaN(time)) { |
Contributor
There was a problem hiding this comment.
time should always be a number once the date prop's type is changed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #139
The react-native-timeago lib was removed (unmaintained, broke peer deps) and left a TODO in the Proxiwash header, so I added a small component instead.