fix(serial): fix SIGSEGV and file descriptor leaks in attachment constructor - #238
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Following merged PR #217,
NewFileHandleSerialPortAttachmentcrashed with SIGSEGV because an invalid read or write descriptor caused an autoreleasedNSErrorto be used by Go after its Objective-C autorelease pool drained. Additionally, two duplicated file descriptors leaked because locally allocatedNSFileHandleobjects were not released after attachment initialization retained them. Finally, CI full VM tests were being cancelled at 3 and 5 minutes despite making progress.Scope
NSErroracross the pool boundary; Go converts it to a plain Go error and releases the retainedNSError.NSFileHandles on success, and releases the first if the second duplication fails.serial_console_test.goto cover invalid read and write handles yieldingEBADFand no attachment, and to ensure absence of descriptor leaks on failure and after success release./dev/fdnames via open directoryReaddirnames, avoidingos.ReadDirwhich causedfstatatbad file descriptor errors on macOS 15 Intel..github/workflows/compile.ymlfrom 3 to 10 minutes.Blast Radius
Changes are scoped entirely to
NewFileHandleSerialPortAttachmenterror handling, file descriptor lifecycle, serial console tests, and the CI compile workflow timeout.Verification
make test/run TARGET=TestNewFileHandleSerialPortAttachmentpassed.