Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #657 +/- ##
==========================================
+ Coverage 67.32% 67.40% +0.08%
==========================================
Files 117 117
Lines 8550 8550
Branches 1510 1512 +2
==========================================
+ Hits 5756 5763 +7
+ Misses 2253 2247 -6
+ Partials 541 540 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nested items in
MudSelectExtendedcan get out of sync with the bound selection in 9.3.0 and the currentdevbranch. Clicking an item's row adds its value, but its checkbox/aria-selectedcan remain false; clicking the same row again then fails to deselect it.Reproduction
Open the select and click the Second row, outside its checkbox. Both values should be selected and visibly checked. Click that row again: only
firstshould remain selected. On the affected version, the bound values and item state disagree, and the second row click does not removesecond.Fix
Nested
MudListExtendedinstances do not maintain independent selected-value fields: their setters return whenParentListis present, and item selection is handled by the parent. Their getters nevertheless read the local fields, so nested items can initialize or synchronize from stale/empty state.Delegate the
SelectedValueandSelectedValuesgetters toParentList, recursively reaching the root selection. This also propagates a cleared/null single selection correctly. The production change is two getter expressions; no public parameters or selection semantics are changed.Add six regression cases covering expanded/collapsed groups, parent-driven updates, selection across groups, deselection, repeated row clicks, and nested single-selection changes/clearing.
Validation
dev: 334 passed, 5 failed. All five failures are in the new regression cases.Commands:
dotnet test tests/CodeBeam.MudBlazor.Extensions.UnitTests/CodeBeam.MudBlazor.Extensions.UnitTests.csproj -p:CI=trueanddotnet build src/CodeBeam.MudBlazor.Extensions/CodeBeam.MudBlazor.Extensions.csproj -p:CI=true.