Birmingham | 26-ITP-May | Toluwalase Tiamiyu | Sprint 2 | Book-library - #511
Open
TTiamiyu wants to merge 5 commits into
Open
Birmingham | 26-ITP-May | Toluwalase Tiamiyu | Sprint 2 | Book-library#511TTiamiyu wants to merge 5 commits into
TTiamiyu wants to merge 5 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
TTiamiyu
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
TTiamiyu
changed the title
TTiamiyu
added
Needs Review
cjyuan
reviewed
Aug 5, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
…s, fixed errors in HTML.
…alidation and status messages
Author
hi, i have gone through the code and i have made the needed adjustment in my last commit, thank you |
TTiamiyu
added
the
Needs Review
cjyuan
reviewed
Aug 5, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Changes look great. Well done.
Comment on lines
+46
to
+49
| <div class="form-group"> | ||
| <label for="pages">Pages:</label> | ||
| <input type="number" class="form-control" id="pages" min="1" required /> | ||
| </div> |
Contributor
There was a problem hiding this comment.
Why not make this input element to accept only whole number?
Comment on lines
+39
to
46
| const pagesValue = Number(pagesInput.value); | ||
| const isRead = checkInput.checked; | ||
|
|
||
| // Validation check | ||
| if (!titleValue || !authorValue || isNaN(pagesValue) || pagesValue <= 0) { | ||
| showStatus("Please enter valid book details.", "danger"); | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
What if pageValue is a number like 3.1416?
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Book library Completed.