Skip to content

London | 26-ITP-May | Liridona-Shehu | Sprint 1 | Destructuring - #514

Open
shehu-dona wants to merge 13 commits into
CodeYourFuture:mainfrom
shehu-dona:feature/destructuring
Open

London | 26-ITP-May | Liridona-Shehu | Sprint 1 | Destructuring #514
shehu-dona wants to merge 13 commits into
CodeYourFuture:mainfrom
shehu-dona:feature/destructuring

Conversation

@shehu-dona

Copy link
Copy Markdown

Self checklist

  • [x ] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [x ] My changes meet the requirements of the task
  • [x ] I have tested my changes
  • [x ] My changes follow the style guide

Changelist

A PR with destructuring exercises..

@shehu-dona shehu-dona added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Flows The name of the module. labels Aug 8, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, some changes may be needed

// Update the parameter to this function to make it work.
// Don't change anything else.
function introduceYourself(___________________________) {
function introduceYourself() {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the comment here and see if you've implemented everything it asked?

function gryffindorforStudent() {
let allStudents = "";
for (let student of hogwarts) {
let { firstName, lastName, house, pet, occupation } = student;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to use all these properties in this function?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 8, 2026
@shehu-dona

Copy link
Copy Markdown
Author

Hello @LonMcGregor,
I read your comments and updated the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Data-Flows The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants