Skip to content

London | 26-ITP-May | Dipa Sarker | Sprint 2 | Book Library Project - #521

Open
Dipa-Sarker wants to merge 1 commit into
CodeYourFuture:mainfrom
Dipa-Sarker:debugging-book-library
Open

London | 26-ITP-May | Dipa Sarker | Sprint 2 | Book Library Project#521
Dipa-Sarker wants to merge 1 commit into
CodeYourFuture:mainfrom
Dipa-Sarker:debugging-book-library

Conversation

@Dipa-Sarker

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Changes made

  • Fixed bugs preventing books from being added correctly to the library.
  • Corrected book information handling, including title, author, and read status.
  • Improved the rendering of book cards on the page.
  • Added/fixed event handling for user interactions.
  • Debugged JavaScript issues using browser developer tools and verified the application behaviour.
    Testing
  • Tested adding new books through the form.
  • Confirmed that book details display correctly.
  • Verified that the read status updates properly.
  • Checked that the application works correctly in the browser using Live Server.

The changes were tested locally and the application is working as expected.

@Dipa-Sarker Dipa-Sarker added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 7, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants