Skip to content

London | 26-ITP-May | Martin Mwaka | Sprint 2 | Book library #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Temceo wants to merge 7 commits into
base: main
Choose a base branch
from
+316 −169
Open

London | 26-ITP-May | Martin Mwaka | Sprint 2 | Book library #523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2a52309
script.js - fix issues - 1. page rendering 2. delete button 3. book a…
Temceo Aug 5, 2026
0baa0bf
index.html - set html lang=en and remove onclick submit() from input …
Temceo Aug 5, 2026
2799fa7
script.js - 1. move all global variables to top of page 2. add submit…
Temceo Aug 5, 2026
948930a
small update
Temceo Aug 5, 2026
cfbfb13
update index.html - correct errors and add a table template - script.…
Temceo Aug 7, 2026
e971cda
update index.html
Temceo Aug 8, 2026
0e2ea0a
update my code to fix issues highlighted by volunteer review
Temceo Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
143 changes: 61 additions & 82 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,96 +1,75 @@
<!DOCTYPE html>
<html>
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="style.css" />
</head>
<html lang="en">

<body>
<div class="jumbotron text-center">
<h1>Library</h1>
<p>Add books to your virtual library</p>
</div>
<head>
<title> Book Library</title>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css">
<link rel="stylesheet" type="text/css" href="style.css">
</head>

<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
Add new book
</button>

<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
<body>
<main>
<header>
<div class="jumbotron text-center">
<h1>Library</h1>
<p>Add books to your virtual library</p>
</div>
</div>

<table class="table" id="display">
<thead class="thead-dark">
<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
Add new book
</button>

<div id="demo" class="collapse">
<form class="form-group" id="add-book">
<div>
<label for="title">Title:</label>
<input type="text" class="form-control" id="title" name="title" required>
<span class="error error-title"></span>
</div>
<div>
<label for="author">Author: </label>
<input type="text" class="form-control" id="author" name="author" required>
<span class="error error-author"></span>
</div>
<div>
<label for="pages">Pages:</label>
<input type="text" class="form-control" id="pages" name="pages" required inputmode="numeric"
pattern="[0-9]*" autocomplete="off">
<span class="error error-pages"></span>
Comment on lines +40 to +43

@cjyuan cjyuan Aug 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not make this input element reject unwanted input values?

@Temceo Temceo Aug 9, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have add bespoke validation that prevents submission unless a whole number is added and an error message is shown to the user until the correct input is added

</div>

<label class="form-check-label" for="check">
<input type="checkbox" class="form-check-input" id="check" name="check" value="read">Read
</label>

<input type="submit" value="Submit" class="btn btn-primary" id="submit-button">
</form>
</div>
</header>
<table id="book-table">
<thead>
<tr>
<th>Title</th>
<th>Author</th>
<th>Number of Pages</th>
<th>Pages</th>
<th>Read</th>
<th></th>
<th>Delete</th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
<tbody id="display-books">

</tbody>
</table>

<script src="script.js"></script>
</body>
</html>

</main>

<script src="script.js" type="module"></script>
</body>

</html>
Loading