Skip to content

Glasgow | 26-ITP-May | Sandani Kannangara | Sprint 2 | Fix library debugging #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SandzSoft wants to merge 7 commits into
base: main
Choose a base branch
from
+123 −120
Open

Glasgow | 26-ITP-May | Sandani Kannangara | Sprint 2 | Fix library debugging #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c4ec8a3
Fix JavaScript syntax errors and delete button functionality
SandzSoft Aug 7, 2026
6b461b0
Fix adding new books to the library
SandzSoft Aug 7, 2026
75edbaa
Fix book validation and improve rendering
SandzSoft Aug 7, 2026
f56e07a
Fix library bugs and improve book management
SandzSoft Aug 7, 2026
cbf351d
Refactor library DOM handling and improve readability
SandzSoft Aug 7, 2026
63d90e2
Fix library bugs and improve book management
SandzSoft Aug 7, 2026
4392a41
Improve HTML validation and form handling
SandzSoft Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 47 additions & 50 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<title> </title>
Expand All @@ -10,6 +10,7 @@
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<script src="script.js" type="module"></script>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
Expand All @@ -28,46 +29,49 @@ <h1>Library</h1>
</button>

<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
<label class="form-check-label">
<form id="book-form">
<div class="form-group">
<label for="title">Title:</label>
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
</div>
type="text"
class="form-control"
id="title"
name="title"
required
/>

<label for="author">Author:</label>
<input
type="text"
class="form-control"
id="author"
name="author"
required
/>

<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
min="1"
required
/>

<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="isRead"
name="isRead"
/>
Read
</label>

<button type="submit" class="btn btn-primary">Submit</button>
</div>
</form>
</div>

<table class="table" id="display">
Expand All @@ -80,17 +84,10 @@ <h1>Library</h1>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>

<tbody id="book-list"></tbody>
</table>

<script src="script.js"></script>
<script src="script.js" type="module"></script>
</body>
</html>
146 changes: 76 additions & 70 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,103 +1,109 @@
let myLibrary = [];

@cjyuan cjyuan Aug 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we declare myLibrary in a way that prevents it from being accidentally reassigned?


window.addEventListener("load", function (e) {
window.addEventListener("load", function () {
populateStorage();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
if (myLibrary.length === 0) {
const book1 = new Book("Robinson Crusoe", "Daniel Defoe", 252, true);
const book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);

myLibrary.push(book1);
myLibrary.push(book2);
render();
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
const titleInput = document.getElementById("title");
const authorInput = document.getElementById("author");
const pagesInput = document.getElementById("pages");
const isReadInput = document.getElementById("isRead");
const bookForm = document.getElementById("book-form");
Comment on lines +23 to +27

@cjyuan cjyuan Aug 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Common practice is to declare all variables before function definitions.


bookForm.addEventListener("submit", function (event) {
event.preventDefault();
addBook();
});
Comment on lines +29 to +32

@cjyuan cjyuan Aug 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not place all "code that runs once on page load" in one place. For example, inside the on page load callback function.


function addBook() {
const title = titleInput.value.trim();
const author = authorInput.value.trim();
const pages = Number.parseInt(pagesInput.value, 10);

if (!title || !author || !Number.isInteger(pages) || pages < 1) {
alert("Please enter valid book details.");
return;
}

const book = new Book(title, author, pages, isReadInput.checked);

myLibrary.push(book);

clearForm();
render();
}

function clearForm() {
titleInput.value = "";
authorInput.value = "";
pagesInput.value = "";
isReadInput.checked = false;
Comment on lines +53 to +56

@cjyuan cjyuan Aug 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also use the form's built-in .reset() method to reset the form.

}

function Book(title, author, pages, check) {
function Book(title, author, pages, isRead) {
this.title = title;
this.author = author;
this.pages = pages;
this.check = check;
this.isRead = isRead;
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
const tableBody = document.getElementById("book-list");

tableBody.replaceChildren();

for (let i = 0; i < myLibrary.length; i++) {
const row = tableBody.insertRow();
const titleCell = row.insertCell();
const authorCell = row.insertCell();
const pagesCell = row.insertCell();
const wasReadCell = row.insertCell();
const deleteCell = row.insertCell();

titleCell.textContent = myLibrary[i].title;
authorCell.textContent = myLibrary[i].author;
pagesCell.textContent = myLibrary[i].pages;

const changeButton = document.createElement("button");
changeButton.className = "btn btn-success";
changeButton.textContent = myLibrary[i].isRead ? "No" : "Yes";

wasReadCell.appendChild(changeButton);

changeButton.addEventListener("click", function () {
myLibrary[i].isRead = !myLibrary[i].isRead;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
const deleteButton = document.createElement("button");
deleteButton.className = "btn btn-warning";
deleteButton.textContent = "Delete";

deleteCell.appendChild(deleteButton);

deleteButton.addEventListener("click", function () {
const deletedTitle = myLibrary[i].title;

myLibrary.splice(i, 1);
render();

alert(`You've deleted title: ${deletedTitle}`);

@cjyuan cjyuan Aug 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alert() is a blocking function call. As a result, invoking it prevents the browser from updating the UI until the dialog is dismissed.

If time permits, research for approaches that allows the UI to update before displaying the alert dialog. (This is an optional change).

});
}
}
Loading