Skip to content

London | 26-ITP-May | Tomislav Dukez | Sprint 1 | Object Destructuring - #527

Open
tomdu3 wants to merge 7 commits into
CodeYourFuture:mainfrom
tomdu3:feature/destructuring
Open

London | 26-ITP-May | Tomislav Dukez | Sprint 1 | Object Destructuring#527
tomdu3 wants to merge 7 commits into
CodeYourFuture:mainfrom
tomdu3:feature/destructuring

Conversation

@tomdu3

@tomdu3 tomdu3 commented Aug 8, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Added solutions for 3 exercises.

@tomdu3 tomdu3 added 🏕 Priority Mandatory This work is expected Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Flows The name of the module. labels Aug 8, 2026
@tomdu3 tomdu3 mentioned this pull request Aug 8, 2026
Open
1 task
LonMcGregor
LonMcGregor reviewed Aug 8, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, but I have some suggestions for areas to look futher

Comment thread Sprint-1/destructuring/exercise-2/exercise.js Outdated
Comment thread Sprint-1/destructuring/exercise-3/exercise.js
@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 8, 2026
@tomdu3 tomdu3 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 8, 2026
LonMcGregor
LonMcGregor reviewed Aug 8, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done

Comment thread Sprint-1/destructuring/exercise-2/exercise.js Outdated
)) {
console.log(person);
}
for (const person of teachersWithPets) {

@LonMcGregor LonMcGregor Aug 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is simpler, but do you know how to use destructuring within the for loop? (e.g. instead of const person)

@tomdu3 tomdu3 Aug 8, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done it.

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 8, 2026
@tomdu3 tomdu3 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Module-Data-Flows The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 🏕 Priority Mandatory This work is expected

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomdu3 @LonMcGregor