London | 26-ITP-May | Tomislav Dukez | Sprint 2 | Book Library - #528
Open
tomdu3 wants to merge 10 commits into
Open
London | 26-ITP-May | Tomislav Dukez | Sprint 2 | Book Library#528tomdu3 wants to merge 10 commits into
tomdu3 wants to merge 10 commits into
Conversation
…esolve syntax errors in rendering logic
tomdu3
added
🏕 Priority Mandatory
tomdu3
changed the title
2 tasks
cjyuan
reviewed
Aug 8, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
tomdu3
added
Needs Review
cjyuan
reviewed
Aug 8, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Changes look pretty solid. There are a few improvements you could still make.
cjyuan
added
Reviewed
tomdu3
added
Needs Review
cjyuan
reviewed
Aug 9, 2026
Comment on lines
+52
to
+61
| if (isPagesInvalid) { | ||
| pagesInput.classList.add("is-invalid"); | ||
| } else { | ||
| pagesInput.classList.remove("is-invalid"); | ||
| } | ||
|
|
||
| if (!titleValue || !authorValue || isPagesInvalid) { | ||
| alert("Please fill all fields with valid information!"); | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
Why show the error message at two different places?
Comment on lines
+75
to
+78
| titleInput.value = ""; | ||
| authorInput.value = ""; | ||
| pagesInput.value = ""; | ||
| checkInput.checked = false; |
| pagesInput.value = ""; | ||
| checkInput.checked = false; | ||
| } | ||
| pagesInput.classList.remove("is-invalid"); |
Contributor
There was a problem hiding this comment.
This statement also appears on line 55. Is it necessary to include it on both places?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Added bug fixes for the Book Library App.