Skip to content

Cape Town|26-ITP-May | Enice Mutanda |Sprint 3|Alarm Clock - #1394

Open
Enice-Codes wants to merge 1 commit into
CodeYourFuture:mainfrom
Enice-Codes:AlarmCoursework-sprint-3
Open

Cape Town|26-ITP-May | Enice Mutanda |Sprint 3|Alarm Clock #1394
Enice-Codes wants to merge 1 commit into
CodeYourFuture:mainfrom
Enice-Codes:AlarmCoursework-sprint-3

Conversation

@Enice-Codes

@Enice-Codes Enice-Codes commented Aug 6, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

added a title in the html file
added code to the function on alarm.js file
followed instructions

Questions

Did we have to leave the alarm.test.js untouched ?

@Enice-Codes Enice-Codes added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 6, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 6, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@Enice-Codes Enice-Codes changed the title Cape Town|2026-May-ITP|Enice Mutanda|Alarm Clock App Cape Town|2026-May-ITP|Enice Mutanda|Sprint1|Alarm Clock App Aug 6, 2026
@Enice-Codes Enice-Codes changed the title Cape Town|2026-May-ITP|Enice Mutanda|Sprint1|Alarm Clock App Cape Town|26-ITP-May | Enice Mutanda |Sprint-1|Alarm Clock Aug 6, 2026
@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 6, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 6, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@Enice-Codes Enice-Codes changed the title Cape Town|26-ITP-May | Enice Mutanda |Sprint-1|Alarm Clock Cape Town|26-ITP-May | Enice Mutanda |Sprint 1|Alarm Clock Aug 6, 2026
@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 6, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 6, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 6, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 6, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 6, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 6, 2026
@github-actions

This comment has been minimized.

@Enice-Codes Enice-Codes changed the title Cape Town|26-ITP-May | Enice Mutanda |Sprint 1|Alarm Clock Cape Town|26-ITP-May | Enice Mutanda |Sprint 3|Alarm Clock Aug 6, 2026
@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 6, 2026
@hey-hammad hey-hammad added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 8, 2026

@hey-hammad hey-hammad left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would happen if the user does the following:

  • enter invalid values for the timer like negative & decimals?
  • stop alarm before it reaches 00:00

@hey-hammad hey-hammad added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants