London | 26-ITP-May | Russom Gebremeskel | Sprint 2 | Coursework/sprint 2

[russom-g]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

I manage to predict, find, interpret and fix the errors in programs. I debugged each files and corrected the programs. I implemented functions based on requirements. I interpreted programs using documentations.

[Liam310]

Hey @russom-g! Just highlighting that you do still have some outstanding comments left on here. There's not a lot of work to do and I'd be happy to mark as complete once they are sorted!

[Liam310]

@russom-g I can see you deleted one of the offending files from Sprint-3 - this isn't quite what we want to do. In a real work scenario, if you deleted it on a branch and the branch gets merged, then that file is deleted in the main branch and that's not what we want to happen. Our aim is to leave that file untouched because it's not relevant to the contents of this sprint. Deleting it is very much still doing something to it - we just want the file to remain as is and not be at all affected by this PR (if you click files changed at the top of this section you can see that the sprint 3 file still appears in there - we don't want to see it there at all).

Also, you may not have seen but there are still two other unresolved comments asking about the data type of a specific value:

• Comment 1
• Comment 2

[russom-g]

@Liam310 I shouldn't have done that. I have tried to do it from vs code id didn't work. Then I taught if I do it on github from my pull request and branch it wouldn't affect the main. I know reverted the commits which pushed the wrong file to the PR from my vs code remotely. This branch mixup and untangling it has been a big headache for me for a few days now.

I am not sure if you have seen the reply to your two last comments about the data types. I did reply a few days ago. Are they not visible to you?

[Liam310]

@russom-g I'm afraid all I can see is this:

So I can't see any reply from you (on either thread) 🤔

[russom-g]

@Liam310 I am not quite sure what is causing this.

[Liam310]

@russom-g Very weird. Do you want to just answer in one of these comments and then we can put it to bed? 🙂

[Liam310]

@russom-g Oh one more thing, I noticed that a familiar issue has popped up again - looks like you've got the whole repo accidentally copied into a subdirectory here inside Sprint-3. Should be deleted, like you did before

[russom-g]

@Liam310 I did remove the wrong file. I hope it worked this time. The questions about the data type, the answer is string.

[russom-g]

@Liam310 The file is removed.

[Liam310]

Done! ✅