Skip to content

London | 26-ITP-May | Russom Gebremeskel | Sprint 3 | Practice TDD - #1530

Open
russom-g wants to merge 32 commits into
CodeYourFuture:mainfrom
russom-g:Sprint-3/2-practice-tdd
Open

London | 26-ITP-May | Russom Gebremeskel | Sprint 3 | Practice TDD#1530
russom-g wants to merge 32 commits into
CodeYourFuture:mainfrom
russom-g:Sprint-3/2-practice-tdd

Conversation

@russom-g

@russom-g russom-g commented Jul 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Multiple test cases written with Jest including special and edge cases prior to writing functions. Afterwards multiple functions implemented to cover for those tests. Some of the test were fixed or rewritten after finding issues.

russom added 12 commits July 4, 2026 21:48
russom
if condition created inside getAngleType function to evaluate the typ…
c4261fd 
…e of angle
russom
Test cases for Right and Obtuse angles created.
3331c94
russom
Test cases for Straight, Reflex and Invalid angles created and tested.
d16b7fb
russom
More test cases added for invalid angles including negative numbers.
c3617ce
russom
A return expression added into isProperFraction function
29fc3b3
russom
Test case for no occurrences scenario for a char in a str created.
94c1f50
russom
Test case for handling 0 and negative counts of a char in a str created.
d4edc9d
russom
Test cases for handling different ordinal numbers created.
e82f88c
russom
countChar function created to check for multiple occurrence of a char…
1fa6def 
… in a str.
russom
.length method added to count char in a str
d37292b
russom
repeatStr function created to check count times is str repeated.
8253891
russom
Unnecessary code removed.
8979be1
@github-actions

This comment has been minimized.

Sign in to view
@russom-g russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 28, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 28, 2026
@github-actions

This comment has been minimized.

Sign in to view
@russom-g russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 28, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 28, 2026
@russom-g russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 29, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 29, 2026
@russom-g russom-g changed the title London | 26-ITP-May | Russom Gebremeskel | Sprint 3 | 2 Practice TDD London | 26-ITP-May | Russom Gebremeskel | Sprint 3 | Practice TDD Jul 30, 2026
@russom-g russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 30, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 30, 2026
@github-actions

This comment has been minimized.

Sign in to view
@russom-g russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 30, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 30, 2026
@russom-g russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 30, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 30, 2026
@russom-g russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 30, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Aug 1, 2026
LonMcGregor
LonMcGregor reviewed Aug 1, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, task complete

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 1, 2026
@russom-g

russom-g commented Aug 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Thanks @LonMcGregor for reviewing my code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@russom-g @LonMcGregor