London | 26-May-ITP | Jorvan White | Sprint 2 | Coursework - #1574
Open
JorvanW wants to merge 16 commits into
Open
London | 26-May-ITP | Jorvan White | Sprint 2 | Coursework#1574JorvanW wants to merge 16 commits into
JorvanW wants to merge 16 commits into
Conversation
…the correct sprint.
This comment has been minimized.
This comment has been minimized.
JorvanW
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
JorvanW
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
added 3 commits
August 3, 2026 17:23
JorvanW
added
the
Needs Review
cjyuan
reviewed
Aug 5, 2026
Comment on lines
+21
to
+26
| function convertToPercentage(decimalNumber) { | ||
| decimalNumber = 0.5; | ||
| const percentage = `${decimalNumber * 100}%`; | ||
| return percentage; | ||
| } | ||
| console.log (convertToPercentage(0.5)); No newline at end of file |
Contributor
There was a problem hiding this comment.
With the current implementation, the function will always return "50%".
How would you modify the function so that it can be easily reused to convert different numbers to their equivalent percentages?
Comment on lines
+19
to
+24
| function Capitalise(inputString) { | ||
| return inputString.toUpperCase() | ||
|
|
||
| } | ||
|
|
||
| Console.log(Capitalise("hello there")); No newline at end of file |
Contributor
There was a problem hiding this comment.
-
Does this function return
"LORD_OF_THE_RINGS"when its parameter is"lord of the rings"? -
Note: The convention of variable and function names in JavaScript is lower camel case -- the name begins with a lowercase letter.
Comment on lines
+10
to
+23
| const penceStringWithoutTrailingP = penceString.substring( | ||
| 0, | ||
| penceString.length - 1 | ||
| ); | ||
|
|
||
| const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0"); | ||
| const pounds = paddedPenceNumberString.substring( | ||
| 0, | ||
| paddedPenceNumberString.length - 2 | ||
| ); | ||
|
|
||
| const pence = paddedPenceNumberString | ||
| .substring(paddedPenceNumberString.length - 2) | ||
| .padEnd(2, "0"); |
Contributor
There was a problem hiding this comment.
The objective of this exercise is to define a function that accepts a pence string as its argument and returns an equivalent pound string.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
London | 26-May-ITP | Jorvan White | Sprint 2 | Coursework
Learners, PR Template
Self checklist
Changelist
This is the Pull request for Module-Structuring and Testing Sprint 2