Skip to content

Birmingham | 26-ITP-May | Gabriel Pawuoi | Sprint 3 | Implement and rewrite tests - #1577

Open
KhotKeys wants to merge 12 commits into
CodeYourFuture:mainfrom
KhotKeys:sprint-3-implement-rewrite
Open

Birmingham | 26-ITP-May | Gabriel Pawuoi | Sprint 3 | Implement and rewrite tests#1577
KhotKeys wants to merge 12 commits into
CodeYourFuture:mainfrom
KhotKeys:sprint-3-implement-rewrite

Conversation

@KhotKeys

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Completed coursework/implement-and-rewrite following the ReadMe instruction.

@KhotKeys KhotKeys added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jul 26, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

Just two comments.

Comment thread Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js Outdated
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 27, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Please note that in ITP, whenever your PR is ready to be re-reviewed, you should also add a "Needs review" label to the PR. Otherwise there is a chance a reviewer may miss a PR that's ready to be re-reviewed.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Structuring-And-Testing-Data The name of the module. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants