Manchester | 26-ITP-May | Monsur Abdulrahman | Sprint 3 | Coursework/sprint 3 | Dead Code

[Monsur0001]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer. You must remove this section if you have no questions.

[Stephanieewelu]

Thanks for the cleanup, nice work removing dead code and unreachable statements. A few issues still need fixing before this is ready to merge.

1. Sprint-1/2-mandatory-errors/4.js
   Blocking: The variable names 12HourClockTime and 24hourClockTime are invalid; JS identifiers can't start with a digit, so this will throw a syntax error. Please rename them to something like twelveHourClockTime and twentyFourHourClockTime.

Also worth standardizing the 12-hour time format (with or without a space before "pm") in case this value gets parsed anywhere downstream.

2. Sprint-3/3-dead-code/exercise-1.js
   Good catch removing the unreachable log statement and the unused variable. Two things remain:

• The outer greeting constant is unused since it's shadowed by the function's own greeting parameter. Either remove the outer one or rename it so the intent is clear.
• The sayHello function is never called or exported, and testName is reassigned but never used. If this is meant to be testable, either export the function or call it directly so its output is visible.

3. Sprint-3/3-dead-code/exercise-2.js
   The line you removed had a broken arrow function token, so good call cutting that. However, the countAndCapitalisePets function is currently incomplete; it stops partway through, before computing the capitalised list or the "starts with H" filter, and before returning anything.

When you finish it, make sure it doesn't mutate the original pets array, computes results from its own parameter rather than reaching out to the global array, and is exported so tests can import it.

Once these are addressed this should be good to merge 👍