Potential fix for code scanning alert no. 18: Clear-text logging of sensitive information - #79
Merged
Merged
Conversation
…ensitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
vladd-bit
marked this pull request as ready for review
July 16, 2026 19:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/CogStack/CogStack-NiFi/security/code-scanning/18
To fix this without changing functionality, keep the error handling behavior exactly the same but stop logging raw
_postcode,_lat, and_longvalues. Replace the current debug line with a generic message that indicates invalid geolocation data was encountered, without embedding record-derived content.Best single change:
nifi/user_python_extensions/record_add_geolocation.pyprocess(...), in theexcept ValueError:block around line 197.self.logger.debug(f"invalid lat/long values for postcode {_postcode}: {_lat}, {_long}")self.logger.debug("invalid lat/long values encountered for a record; geolocation not set")No imports, new methods, or dependencies are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.