fix(medcat): Fix config defaulting to train=True. - #591
Merged
Conversation
This default would normally be fixed at model load time or at inference time (see calls to ). However, when building a new model (e.g with a mostly default config), the value would remain . And if there is no save/load or inference before training, this would fail to train because of it. PS: To reiterate, this would not have affected any users down the line since there's fixes at model load time. This would have only affected new model creation (with default/unchanged config).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This default would normally be fixed at model load time or at inference time (see calls to ). However, when building a new model (e.g with a mostly default config), the value would remain . And if there is no save/load or inference before training, this would fail to train because of it.
PS: To reiterate, this would not have affected any users down the line since there's fixes at model load time. This would have only affected new model creation (with default/unchanged config).