Skip to content

chore(hygiene): drop the internal ticket id from test_deprecated_nodes - #822

Closed
skishore23 wants to merge 1 commit into
mainfrom
chore/hygiene-be7684
Closed

chore(hygiene): drop the internal ticket id from test_deprecated_nodes#822
skishore23 wants to merge 1 commit into
mainfrom
chore/hygiene-be7684

Conversation

@skishore23

Copy link
Copy Markdown
Contributor

The public-repo-hygiene check flags ticket-shaped ids. This one arrived in #808 and has kept main (and every open PR, whose merge ref includes it) red since. The sentence loses nothing without it.

🤖 Generated with Claude Code

The public-repo-hygiene check flags ticket-shaped ids; this one arrived in
#808 and has kept main and every open PR red since. The sentence loses
nothing.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 28, 2026
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8eb50c2c-082f-4344-b819-9bd57ca473eb

📥 Commits

Reviewing files that changed from the base of the PR and between 929198f and 0f9dc3c.

📒 Files selected for processing (1)
  • tests/comfy_cli/command/test_deprecated_nodes.py

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 6 reviews per hour.


📝 Walkthrough

Walkthrough

The deprecated-node documentation removes the (BE-7684) reference from the ImageBatch description. The documentation still describes deprecated-node ranking in nodes search.

Changes

Deprecated node documentation

Layer / File(s) Summary
Remove obsolete issue reference
tests/comfy_cli/command/test_deprecated_nodes.py
The ImageBatch documentation removes the (BE-7684) reference while retaining the deprecated-node ranking description.

Suggested reviewers: annehe9

Merge Risk: ⚪ Minimal · up to 0f9dc

This is a narrowly scoped test-text cleanup with no behavior or production impact; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/hygiene-be7684
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch chore/hygiene-be7684

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from annehe9 August 28, 2026 17:22
@skishore23

Copy link
Copy Markdown
Contributor Author

Closing — the same one-line fix ships at the base of the open stack (#809, commit 7aba70f), so no separate PR is needed.

@skishore23 skishore23 closed this Aug 28, 2026
@skishore23
skishore23 deleted the chore/hygiene-be7684 branch August 28, 2026 17:23
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant