fix(nav): make the footer and logo links relative - #1539
Conversation
docs.json hardcoded https://docs.comfy.org in the logo href and the nine footer Resources links (en, ja, ko). Every other link on the site is relative, so these were the only ones that jumped a Mintlify preview deployment back to production. Relative hrefs keep the reader on whatever host is serving the page, preview or prod, and survive a domain change.
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: 9 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour. 📝 WalkthroughWalkthroughThe footer now includes Chinese navigation links. Japanese, Korean, and default footer links use site-relative paths. The logo links to ChangesFooter navigation
Suggested reviewers: Merge Risk: ⚪ Minimal · up to This localized documentation change makes footer and logo links work correctly on preview deployments without altering content or navigation structure; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
The zh language object had no footer block, so Chinese pages fell back to the English global footer (all labels in English). Add a zh footer mirroring the ja/ko structure with Simplified Chinese labels and localized hrefs.
|
Added a localized The I added a
All three zh target pages exist, so the links resolve. Commit: 20c352a. |
Summary
Ten
hrefs indocs.jsonhardcodedhttps://docs.comfy.org: the logo link and the footer "Resources" links (installation, Tutorials, Development) in English, Japanese and Korean. Every other link on the site is relative, so these were the only places where clicking on a Mintlify preview deployment jumped back to production. They are now relative (/,/installation/system_requirements,/ja/...,/ko/...).Details
docs.jsononly, 10 lines. All nine target pages exist at the relative paths (installation/system_requirements.mdx,tutorials/basic/text-to-image.mdx,development/overview.mdx, plus theja/andko/copies). No content or navigation structure changes.Testing
docs.jsonparses..mdxfiles exist in the tree.https://docs.comfy.orgindocs.json.