Skip to content

fix(nav): make the footer and logo links relative - #1539

Merged
comfyui-wiki merged 2 commits into
mainfrom
docs/relative-site-links
Aug 28, 2026
Merged

fix(nav): make the footer and logo links relative#1539
comfyui-wiki merged 2 commits into
mainfrom
docs/relative-site-links

Conversation

@mattmillerai

Copy link
Copy Markdown
Contributor

Summary

Ten hrefs in docs.json hardcoded https://docs.comfy.org: the logo link and the footer "Resources" links (installation, Tutorials, Development) in English, Japanese and Korean. Every other link on the site is relative, so these were the only places where clicking on a Mintlify preview deployment jumped back to production. They are now relative (/, /installation/system_requirements, /ja/..., /ko/...).

Details

docs.json only, 10 lines. All nine target pages exist at the relative paths (installation/system_requirements.mdx, tutorials/basic/text-to-image.mdx, development/overview.mdx, plus the ja/ and ko/ copies). No content or navigation structure changes.

Testing

  • docs.json parses.
  • All nine target .mdx files exist in the tree.
  • No remaining https://docs.comfy.org in docs.json.

docs.json hardcoded https://docs.comfy.org in the logo href and the nine
footer Resources links (en, ja, ko). Every other link on the site is
relative, so these were the only ones that jumped a Mintlify preview
deployment back to production. Relative hrefs keep the reader on whatever
host is serving the page, preview or prod, and survive a domain change.
@mintlify

mintlify Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
comfy 🟢 Ready View Preview Aug 27, 2026, 10:54 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: bcd43ef0-af98-426a-9a15-96435ef92c14

📥 Commits

Reviewing files that changed from the base of the PR and between f63e540 and 20c352a.

📒 Files selected for processing (1)
  • docs.json

Included review availability: 9 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.


📝 Walkthrough

Walkthrough

The footer now includes Chinese navigation links. Japanese, Korean, and default footer links use site-relative paths. The logo links to /.

Changes

Footer navigation

Layer / File(s) Summary
Chinese footer navigation
docs.json
Added Chinese GitHub, X, Discord, YouTube, resource, product, and company links.
Relative footer and logo links
docs.json
Changed Japanese, Korean, and default footer links to site-relative paths. Changed the logo destination to /.

Suggested reviewers: comfyui-wiki, lin-bot23, robinjhuang, stale2000

Merge Risk: ⚪ Minimal · up to 20c35

This localized documentation change makes footer and logo links work correctly on preview deployments without altering content or navigation structure; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/relative-site-links
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch docs/relative-site-links

Comment @coderabbitai help to get the list of available commands.

The zh language object had no footer block, so Chinese pages fell back
to the English global footer (all labels in English). Add a zh footer
mirroring the ja/ko structure with Simplified Chinese labels and
localized hrefs.
@comfyui-wiki

Copy link
Copy Markdown
Member

Added a localized zh footer to docs.json.

The zh language object had no footer block, so Chinese pages fell back to the English global footer (all labels in English: Resources / Products / Company). This PR's relative-href fix only touched the en/ja/ko footers, leaving the Chinese footer unlocalized.

I added a zh footer mirroring the ja/ko structure:

  • 资源 → 安装 / 教程 / 开发 (localized hrefs: /zh/installation/system_requirements, /zh/tutorials/basic/text-to-image, /zh/development/overview)
  • 产品 → 功能 / 画廊 / 下载
  • 公司 → 关于 / 招聘 / 服务条款 / 隐私政策

All three zh target pages exist, so the links resolve. Commit: 20c352a.

@comfyui-wiki
comfyui-wiki merged commit 47f2fbf into main Aug 28, 2026
9 of 10 checks passed
@github-actions
github-actions Bot deleted the docs/relative-site-links branch August 28, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger Cursor automated review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants