Skip to content

fix: scope dashboard commitments by owner and show per-asset totals - #2115

Open
abdulraheemabdullahi30-tech wants to merge 5 commits into
Commitlabs-Org:masterfrom
abdulraheemabdullahi30-tech:security/issue-2082-frontend-show-per-asset-totals-and-owner-scoped
Open

abdulraheemabdullahi30-tech wants to merge 5 commits into
Commitlabs-Org:masterfrom
abdulraheemabdullahi30-tech:security/issue-2082-frontend-show-per-asset-totals-and-owner-scoped

Conversation

@abdulraheemabdullahi30-tech

@abdulraheemabdullahi30-tech abdulraheemabdullahi30-tech commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Overview

This PR fixes the dashboard so that "Total locked" and "Projected yield" no longer add USDC, XLM and EURC amounts into one meaningless number, and so the commitment list is scoped to the connected wallet. It also makes the "Ready to settle" count always visible and formats remaining time in hours/minutes during the final day.

Related Issue

Changes

📊 Per-asset totals and owner scoping

  • [MODIFY] src/app/dashboard/dashboard.test.tsx

    • Adds component coverage for owner filtering with a mocked useWallet across two addresses and the disconnected case.
    • Asserts that per-asset totals render with their unit symbols and that the "Ready to settle" count is visible regardless of connection state.
  • [MODIFY] src/app/globals.css

    • Adds layout styles for the per-asset total rows and the dedicated "Ready to settle" / wallet balance tiles.
    • Ensures the dashboard tiles and list wrap correctly at 390px without horizontal scroll.

Verification Results

npm test -- src/app/dashboard/dashboard.test.tsx
✅ dashboard component tests passing (owner filtering: wallet A, wallet B, disconnected)
Acceptance Criteria Status
No tile ever adds amounts of different assets ✅ Totals rendered per asset
Each asset total shows its unit symbol ✅ Unit symbols shown per asset row
"Ready to settle" count is visible whether or not a wallet is connected ✅ Dedicated tile always rendered
Connecting wallet A shows only A's commitments plus the demo group; switching to wallet B updates the list ✅ Covered by dashboard component test
A commitment 5 hours from maturity shows "5h left", not "0 days" ✅ Covered by remaining-time formatting
Layout works at 390px without horizontal scroll ✅ Responsive tile/list styles added

Closes #2082

@vercel

vercel Bot commented Oct 19, 2026

Copy link
Copy Markdown

@abdulraheemabdullahi30-tech is attempting to deploy a commit to the 1nonly's projects Team on Vercel.

A member of the Team first needs to authorize it.

@abdulraheemabdullahi30-tech
abdulraheemabdullahi30-tech force-pushed the security/issue-2082-frontend-show-per-asset-totals-and-owner-scoped branch from c3a18ce to 44e100f Compare October 22, 2026 00:35
Strips the payload this branch picked up (deleted api.js, truncated next.config.js, unhooked package.json). No functional change to the branch's own work.
@drips-wave

drips-wave Bot commented Oct 22, 2026

Copy link
Copy Markdown

@abdulraheemabdullahi30-tech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@1nonlypiece

Copy link
Copy Markdown
Contributor

Hi @abdulraheemabdullahi30-tech, thanks for the PR. We can't merge it yet: it adds these two lines to .gitignore:

temp_auto_push.bat
temp_interactive_push.bat

These entries are a known indicator of a malware campaign that infects developer machines and auto-pushes hidden code to their repositories. The malware adds them to hide its own helper scripts. We didn't find the payload itself in this PR's diff, but this usually means the machine the commits came from is compromised.

What to do before we can merge this PR

  1. Assume the machine you pushed from is infected. This campaign (publicly tracked as PolinRider) spreads by modifying config files on developers' machines and pushing them automatically, so you may not have added it yourself.
  2. From a clean device, rotate your GitHub tokens/SSH keys and any wallet seed phrases or keys that were on that machine.
  3. Remove the code described above, rebase onto the latest default branch, and check that the PR diff contains only your intended changes (no trailing code after export default / module.exports, no .bat entries in .gitignore, no changes to .vscode/, fonts or install scripts).
  4. Push the cleaned branch and leave a comment here. We will re-scan it and merge it if it is clean.

Thanks for your contribution, and sorry for the hassle. We have to be strict about this to keep the repository and everyone who clones it safe.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[frontend] Show per-asset totals and owner-scoped commitments on the dashboard

3 participants