Repository navigation
Conversation
parseRAVENargs accepts everything parseGECKOargs did and also leading positional arguments followed by name-value pairs. Only the error identifiers change, from parseGECKOargs:* to parseRAVENargs:*.
…ns of RAVEN constrainFluxData, loadEvotuneData and evotuneScore call RAVEN's applyFluxDataConstraints, loadExperimentData, simulateConditions, computeCarbonWeights and experimentDistance, and add the biomass reaction, the carbon source, the anaerobic and protein-content functions and the kcat penalty of the model adapter. loadFluxData and fillCarbonNum are removed; RAVEN has loadFluxData(path) and computeCarbonWeights. The experimental data files are fluxData.tsv, maxGrowth.tsv and zeroFlux.tsv, with the column weight, and the data structure has the fields fluxData, maxGrowth and zeroFlux. The evotune functions take the argument experimentData (was evoData). evotuneScore returns the carbon weights as its fourth output and takes them as the argument carbonWeights, so they are computed once per run. addCarbonNum and getcarbonnum raise GECKO:removedFunction and name computeCarbonWeights. GECKOInstaller checks that RAVEN has the experiments functions.
Unit test results0 tests 0 ✅ 0s ⏱️ Results for commit f84240c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
This is a draft. It needs a RAVEN release with
src/experiments(CompMetEng/RAVEN#28) first.parseGECKOargsis removed, and every function uses RAVEN'sparseRAVENargs. It accepts everythingparseGECKOargsdid, and also leading positional arguments followed by name-value pairs. The error identifiers change fromparseGECKOargs:*toparseRAVENargs:*, andfuzzyKcatMatching(ecModel, [], adapter, 'kcatAggregation', 'median')is valid now.constrainFluxData,loadEvotuneDataandevotuneScorecallapplyFluxDataConstraints,loadExperimentData,simulateConditions,computeCarbonWeightsandexperimentDistanceof RAVEN, and add the biomass reaction, the carbon source, the anaerobic and protein-content functions and the kcat penalty of the model adapter.loadFluxDataandfillCarbonNumare removed, andaddCarbonNumandgetcarbonnumraiseGECKO:removedFunctionand namecomputeCarbonWeights.fluxData.tsv,maxGrowth.tsvandzeroFlux.tsv, with the columnweight, and the data structure has the fieldsfluxData,maxGrowthandzeroFlux. The evotune functions takeexperimentData(wasevoData), andevotuneScorereturns the carbon weights as its fourth output.GECKOInstallerchecks that RAVEN has the experiments functions. The tutorial data files are renamed in the same way.geckopy has the same changes (CompMetEng/geckopy#98).
Instructions on merging this PR:
developas target branch, and will be resolved with a squash-merge.mainas target branch, and will be resolved with a merge commit.