Skip to content

refactor: use RAVEN's parseRAVENargs and experiments functions - #38

Draft
edkerk wants to merge 2 commits into
developfrom
refactor/parse-raven-args
Draft

edkerk wants to merge 2 commits into
developfrom
refactor/parse-raven-args

Conversation

@edkerk

@edkerk edkerk commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Main improvements in this PR:

This is a draft. It needs a RAVEN release with src/experiments (CompMetEng/RAVEN#28) first.

  • refactor:
    • parseGECKOargs is removed, and every function uses RAVEN's parseRAVENargs. It accepts everything parseGECKOargs did, and also leading positional arguments followed by name-value pairs. The error identifiers change from parseGECKOargs:* to parseRAVENargs:*, and fuzzyKcatMatching(ecModel, [], adapter, 'kcatAggregation', 'median') is valid now.
    • constrainFluxData, loadEvotuneData and evotuneScore call applyFluxDataConstraints, loadExperimentData, simulateConditions, computeCarbonWeights and experimentDistance of RAVEN, and add the biomass reaction, the carbon source, the anaerobic and protein-content functions and the kcat penalty of the model adapter. loadFluxData and fillCarbonNum are removed, and addCarbonNum and getcarbonnum raise GECKO:removedFunction and name computeCarbonWeights.
    • The experimental data are in fluxData.tsv, maxGrowth.tsv and zeroFlux.tsv, with the column weight, and the data structure has the fields fluxData, maxGrowth and zeroFlux. The evotune functions take experimentData (was evoData), and evotuneScore returns the carbon weights as its fourth output.
    • GECKOInstaller checks that RAVEN has the experiments functions. The tutorial data files are renamed in the same way.

geckopy has the same changes (CompMetEng/geckopy#98).

Instructions on merging this PR:

  • This PR has develop as target branch, and will be resolved with a squash-merge.
  • This PR has main as target branch, and will be resolved with a merge commit.

parseRAVENargs accepts everything parseGECKOargs did and also leading
positional arguments followed by name-value pairs. Only the error
identifiers change, from parseGECKOargs:* to parseRAVENargs:*.
…ns of RAVEN

constrainFluxData, loadEvotuneData and evotuneScore call RAVEN's
applyFluxDataConstraints, loadExperimentData, simulateConditions,
computeCarbonWeights and experimentDistance, and add the biomass reaction,
the carbon source, the anaerobic and protein-content functions and the kcat
penalty of the model adapter. loadFluxData and fillCarbonNum are removed;
RAVEN has loadFluxData(path) and computeCarbonWeights.

The experimental data files are fluxData.tsv, maxGrowth.tsv and zeroFlux.tsv,
with the column weight, and the data structure has the fields fluxData,
maxGrowth and zeroFlux. The evotune functions take the argument experimentData
(was evoData). evotuneScore returns the carbon weights as its fourth output and
takes them as the argument carbonWeights, so they are computed once per run.
addCarbonNum and getcarbonnum raise GECKO:removedFunction and name
computeCarbonWeights. GECKOInstaller checks that RAVEN has the experiments
functions.
@github-actions

Copy link
Copy Markdown

Unit test results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit f84240c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant