Repository navigation
Rename remove_duplicate_reactions to contract_model - #201
Merged
Merged
Conversation
contract_model follows RAVEN's contractModel and takes dist_reverse, the distReverse option. The name remove_duplicate_reactions is removed.
edkerk
added a commit
to CompMetEng/raven-docs
that referenced
this pull request
Nov 17, 2026
…draft (#127) The Python function that corresponds to `contractModel` is `contract_model` ([raven-toolbox#201](CompMetEng/raven-toolbox#201)). The pair list and the guide on combining models name it, and the table of return values states that `contract_model` returns the ids of the removed reactions and `simplify_model` returns `None`. The guide to reconstruction from homology states what a template gene does that maps to a new gene which an earlier template already maps, under `preferredOrder` ([RAVEN#26](CompMetEng/RAVEN#26), [raven-toolbox#200](CompMetEng/raven-toolbox#200)): it counts as a missing subunit, and `complexPolicy` decides what happens to it. The submodules point to the current `develop` of RAVEN and raven-toolbox, which define `contract_model`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
manipulation.contract_modelis the new name ofremove_duplicate_reactions, after RAVEN'scontractModel, and the old name is removed.contract_modeltakesdist_reverse(defaultTrue), thedistReverseoption ofcontractModel: withFalse, reactions with the same metabolites and a different reversibility are duplicates.simplify_modelandreplace_metabolitecallcontract_model.The parity ledger of raven-gecko-parity and the curated name pairs of raven-docs follow in their own pull requests.