Skip to content

[T3663] FIX: don't print B2S letters whose page images can't be loaded - #2207

Merged
Danielgergely merged 1 commit into
18.0from
T3663-b2s-missing-image
Nov 9, 2026
Merged

Danielgergely merged 1 commit into
18.0from
T3663-b2s-missing-image

Conversation

@Danielgergely

Copy link
Copy Markdown
Member

T3663 – When a B2S letter's page images can't be loaded (Cloudinary and Connect both fail), the PDF was still built with only the translation, and the letter could be printed like that.

Before building the PDF of a physical letter without a stored GMC PDF, we now check that every scanned page loads. If one doesn't, the letter isn't attached, the job is switched to manual, and "The letter image is missing!" is posted in its chatter. Refresh once Connect is back.

@Danielgergely

Copy link
Copy Markdown
Member Author

Tested on stage

@Danielgergely
Danielgergely marked this pull request as ready for review November 9, 2026 09:58
@Danielgergely
Danielgergely merged commit 2cce457 into 18.0 Nov 9, 2026
1 check passed
@Danielgergely
Danielgergely deleted the T3663-b2s-missing-image branch November 9, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant