Repository navigation
[T3663] FIX: don't print B2S letters whose page images can't be loaded - #2207
Merged
Merged
Conversation
Member
Author
|
Tested on stage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
T3663 – When a B2S letter's page images can't be loaded (Cloudinary and Connect both fail), the PDF was still built with only the translation, and the letter could be printed like that.
Before building the PDF of a physical letter without a stored GMC PDF, we now check that every scanned page loads. If one doesn't, the letter isn't attached, the job is switched to manual, and "The letter image is missing!" is posted in its chatter. Refresh once Connect is back.