Repository navigation
[T3646] FIX: own layout for GMC S10 child letters, no translation over page 2's printed text #2213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import logging | ||
|
|
||
| from openupgradelib import openupgrade | ||
|
|
||
| _logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| @openupgrade.migrate() | ||
| def migrate(env, version): | ||
| # T3646: S10 letters printing their translation over page 2's printed text | ||
| l1 = env.ref("sbc_compassion.b2s_l1") | ||
| messages = env["gmc.message"].search([("content", "like", "-1S10-")]) | ||
| messages = messages.filtered(lambda m: m.action_id.model == "correspondence") | ||
| letter_ids = [ | ||
| int(letter_id) | ||
| for message in messages | ||
| for letter_id in (message.object_ids or str(message.object_id)).split(",") | ||
| if letter_id.strip().isdigit() | ||
| ] | ||
| letters = env["correspondence"].search( | ||
| [("id", "in", letter_ids), ("template_id", "=", l1.id)] | ||
| ) | ||
| letters = letters.filtered( | ||
| lambda letter: any( | ||
| len((paragraph.translated_text or "").strip()) >= 5 | ||
| for paragraph in letter.page_ids[1:2].paragraph_ids | ||
| ) | ||
| ) | ||
| _logger.info("Move %s letters to the S10 layout", len(letters)) | ||
| letters.write({"template_id": env.ref("sbc_compassion.b2s_l1_s10").id}) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
object_ids. Butprocess_commkitsupports aResponsesbatch and returns all its letter IDs. If a batch contains both S10 and ordinary L1 letters, ordinary L1 letters with page-2 translations also get moved to the S10 layout. Their valid page-2 translation area is removed, and their text moves to an extra page when composed. Parse each response'sTemplateand match only its own letter before changingtemplate_id.