Repository navigation
Conversation
…site The login, signup (with its consent checkbox), password, contact us and child protection charter views of the module are bound to the MyCompassion website: a second one, like Poland's, showed Odoo's stock pages, and its open signup asked no consent. Each MyCompassion website now gets a copy of them, with the same key so that module updates refresh it. Assisted-by: claude-opus-5-5, medium, claude-code
davidwul
force-pushed
the
18.0-my2-views-every-website
branch
from
November 4, 2026 17:04
0dad0d0 to
17aef41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during the review of #443: the MyCompassion PL website showed Odoo's stock login and signup pages. Its signup is open (b2c) and asked no consent at all.
Cause
Nine views of
my_compassionare bound tomy_compassion.my2_website(website_id=in their XML):acceptance_fullconsent checkbox, and the signup form;A second MyCompassion website, like Poland's, does not get them.
Fix
_configure_my_compassion_portal, already run when a MyCompassion website is created, by the install hook and by migrations, now copies these views to every other MyCompassion website:xml_id == key), not the copy-on-write copies ofmy2_website;my_compassion_switzerland.my2_signup_form_inherit_ch(the Swiss registration guide);The post-migration
18.0.1.0.34runs it on existing databases.Tests
TestMy2WebsiteViews: a second MyCompassion website gets the nine copies once, with the same key and parent, and its/web/signupshows the consent checkbox./web/signup,/web/login,/web/reset_passwordand/contactusanswer 200 with the MyCompassion pages;Note
The version is
18.0.1.0.34, because #443 takes18.0.1.0.33. Whichever is merged second gets a trivial conflict on the manifest's version line.Deploy:
-u my_compassion.🤖 Generated with Claude Code