Repository navigation
Conversation
The number of results was followed by the plural text whatever the count. The template now holds the singular text too, shown when there is exactly one result. Translations updated in every language of the module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[T3624] Childpool: "1 child found" instead of "1 children found"
Problem
On the MyCompassion childpool (
/my2/sponsorships), the number of results is always followed by the plural: "1 Kinder gefunden", "1 enfants trouvés", "1 bambini trovati", "1 children found".Cause
The template has a single text after the number ("children found"); the script only updates the number.
Change
Polish uses a third form for 2 to 4 ("znalezione dzieci"), not covered here.
Tests
Manual test on
/my2/sponsorships: filtered down to a single child, the label reads "1 child found" / "1 Kind gefunden" / "1 enfant trouvé" / "1 bambino trovato", and the plural again with more children.Deploy
-u my_compassion(template and translations).