Skip to content

Pid file handling #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thmarx merged 3 commits into from
Sep 8, 2026
Merged

Pid file handling #770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
879d87c
fix different pid file format
thmarx Aug 26, 2026
6e1d9b6
handling exception
thmarx Aug 26, 2026
7f5d72d
fix sonar issues
thmarx Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions cms-server/src/main/java/com/condation/cms/CMSServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,8 @@



import com.condation.cms.api.Constants;
import com.condation.cms.api.utils.ServerUtil;

import com.condation.cms.cli.tools.CLIServerUtils;
import java.io.IOException;
import java.nio.file.Files;
import java.util.Properties;
import lombok.extern.slf4j.Slf4j;
import org.semver4j.Semver;
Expand All @@ -40,18 +37,11 @@
public class CMSServer {

public static boolean isRunning () {
var pidFile = ServerUtil.getPath(Constants.PID_FILE);
if (!Files.exists(pidFile)) {
return false;
}
try {
var pid = Files.readString(pidFile);

return ProcessHandle.of(Long.parseLong(pid)).isPresent();
} catch (IOException ex) {
log.error("", ex);
}
return false;
try {
return CLIServerUtils.getCMSProcess().isPresent();
} catch (IOException ioe) {
throw new RuntimeException(ioe);
}
}

public static Semver getVersion () {
Expand Down
8 changes: 2 additions & 6 deletions cms-server/src/main/java/com/condation/cms/cli/commands/host/ReloadHost.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import com.condation.cms.api.Constants;
import com.condation.cms.api.ServerProperties;
import com.condation.cms.api.utils.ServerUtil;
import com.condation.cms.cli.tools.CLIServerUtils;
import com.condation.cms.core.configuration.ConfigurationFactory;
import com.condation.cms.core.configuration.properties.ExtendedServerProperties;
import com.condation.cms.ipc.Command;
Expand Down Expand Up @@ -84,12 +85,7 @@ public void run() {
}

private static Optional<ProcessHandle> getCMSProcess () throws Exception {
var pidFile = ServerUtil.getPath(Constants.PID_FILE);
if (!Files.exists(pidFile)) {
return Optional.empty();
}
var pid = Files.readString(pidFile);
return ProcessHandle.of(Long.parseLong(pid.trim()));
return CLIServerUtils.getCMSProcess();
}


Expand Down
8 changes: 2 additions & 6 deletions cms-server/src/main/java/com/condation/cms/cli/commands/repo/Checkout.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import com.condation.cms.api.Constants;
import com.condation.cms.api.ServerProperties;
import com.condation.cms.api.utils.ServerUtil;
import com.condation.cms.cli.tools.CLIServerUtils;
import com.condation.cms.core.configuration.ConfigurationFactory;
import com.condation.cms.core.configuration.properties.ExtendedServerProperties;
import com.condation.cms.ipc.Command;
Expand Down Expand Up @@ -84,12 +85,7 @@ public void run() {
}

private static Optional<ProcessHandle> getCMSProcess () throws Exception {
var pidFile = ServerUtil.getPath(Constants.PID_FILE);
if (!Files.exists(pidFile)) {
return Optional.empty();
}
var pid = Files.readString(pidFile);
return ProcessHandle.of(Long.parseLong(pid.trim()));
return CLIServerUtils.getCMSProcess();
}


Expand Down
Loading