Repository navigation
feat(example-sets): Omgevingsvergunning declares the six fields its regulier versions inherit - #4664
Merged
rubenvdlinde merged 1 commit intoOct 26, 2026
Conversation
…egulier versions inherit The Zuiddrecht set adds six fields to the shared parent Omgevingsvergunning: Locatie (required, from the BAG), Aanvrager (required), Datum indiening DSO, Omschrijving van het project, DSO-verzoeknummer and Kadastraal perceel. The set's six omgevingsvergunning cases answer Locatie and Datum indiening DSO, and Aanvrager where the case names a requester. The regulier fields get the order the Velden board draws, with the inherited ones in between. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
October 26, 2026 05:37
Contributor
Quality Report — ConductionNL/dossiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-debt-ratchet | ❌ | ||||
| check-types-e2e | ✅ | ||||
| composer | ✅ | ✅ 109/109 | |||
| npm | ❌ | ✅ 658/658 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-26 05:55 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Example data only, in
lib/Settings/example-sets/zuiddrecht.json, as the coordinator decided after #4662. DqZaaktypeVelden draws Omgevingsvergunning regulier with 6 of its fields inherited from Omgevingsvergunning. The set now adds those 6 fields to the shared parentomgevingsvergunning(found with aparentlookup):locatie)propertySourcebagaanvrager)datumIndieningDso)omschrijvingProject)dsoVerzoeknummer)kadastraalPerceel)The board names only the first three. I chose the other three to match what an Omgevingsloket application carries; the coordinator can rename them.
The set's 6 omgevingsvergunning cases now answer these fields in
properties:The server does not enforce
isRequiredwhen a case is saved; only a case moving to another type checks it. So no existing case breaks.The regulier fields get the
orderthe board draws (Bouwkosten 1, Soort bouwwerk 2, Welstandsgebied 5, Situatietekening 10), so they interleave with Locatie (3), Aanvrager (4) and Datum indiening DSO (6).Tests
tests/Unit/Settings/ZuiddrechtOmgevingsvergunningInheritedFieldsTest.php(3 cases). It failed before the data change and passes now. It checks the six fields, the answers on the six cases (all declared after the fields, all pointing at the right definition), and the board order.tests/Unit/Settings: 672 tests green. The 2 warnings come fromSeededCaseTypeCategoriesTest; they were there before this change.composer check:stricthas not run yet. DQ-DATA3 runs it serially.This PR was prepared with AI assistance (Claude Code, claude-opus-5-5) and needs human review before merge.
check:strict (run by DQ-DATA3)
Ran once on 9fd5a43 and exited 0: lint, phpcs, phpmd, psalm and phpstan clean; 9872 tests green.