Skip to content

feat(example-sets): Omgevingsvergunning declares the six fields its regulier versions inherit - #4664

Merged
rubenvdlinde merged 1 commit into
developmentfrom
r26/exset-omgevingsvergunning-inherited-fields
Oct 26, 2026
Merged

rubenvdlinde merged 1 commit into
developmentfrom
r26/exset-omgevingsvergunning-inherited-fields

Conversation

@rubenvdlinde

@rubenvdlinde rubenvdlinde commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

What changed

Example data only, in lib/Settings/example-sets/zuiddrecht.json, as the coordinator decided after #4662. DqZaaktypeVelden draws Omgevingsvergunning regulier with 6 of its fields inherited from Omgevingsvergunning. The set now adds those 6 fields to the shared parent omgevingsvergunning (found with a parent lookup):

Field Kind Required
Locatie (locatie) text, propertySource bag yes
Aanvrager (aanvrager) text yes
Datum indiening DSO (datumIndieningDso) date, hidden on create no
Omschrijving van het project (omschrijvingProject) text no
DSO-verzoeknummer (dsoVerzoeknummer) text, hidden on create no
Kadastraal perceel (kadastraalPerceel) text no

The board names only the first three. I chose the other three to match what an Omgevingsloket application carries; the coordinator can rename them.

The set's 6 omgevingsvergunning cases now answer these fields in properties:

  • Locatie on all six, taken from the case title.
  • Datum indiening DSO on all six, the day the case was received.
  • Aanvrager on the 4 cases that name a requester. The two closed cases (Dakkapel Lindelaan 12, Schutting Parkweg 8) name nobody, so their Aanvrager stays empty.

The server does not enforce isRequired when a case is saved; only a case moving to another type checks it. So no existing case breaks.

The regulier fields get the order the board draws (Bouwkosten 1, Soort bouwwerk 2, Welstandsgebied 5, Situatietekening 10), so they interleave with Locatie (3), Aanvrager (4) and Datum indiening DSO (6).

Tests

  • New tests/Unit/Settings/ZuiddrechtOmgevingsvergunningInheritedFieldsTest.php (3 cases). It failed before the data change and passes now. It checks the six fields, the answers on the six cases (all declared after the fields, all pointing at the right definition), and the board order.
  • tests/Unit/Settings: 672 tests green. The 2 warnings come from SeededCaseTypeCategoriesTest; they were there before this change.
  • phpcs is clean on the new test.

composer check:strict has not run yet. DQ-DATA3 runs it serially.

This PR was prepared with AI assistance (Claude Code, claude-opus-5-5) and needs human review before merge.

check:strict (run by DQ-DATA3)

Ran once on 9fd5a43 and exited 0: lint, phpcs, phpmd, psalm and phpstan clean; 9872 tests green.

…egulier versions inherit

The Zuiddrecht set adds six fields to the shared parent Omgevingsvergunning:
Locatie (required, from the BAG), Aanvrager (required), Datum indiening DSO,
Omschrijving van het project, DSO-verzoeknummer and Kadastraal perceel. The
set's six omgevingsvergunning cases answer Locatie and Datum indiening DSO, and
Aanvrager where the case names a requester. The regulier fields get the order
the Velden board draws, with the inherited ones in between.

Assisted-by: ClaudeCode:claude-opus-5-5
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/dossiq @ 574aa44

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ❌
stylelint ✅
build ✅
check-manifest ✅
check-vue3-compile ✅
test-l10n ✅
format ❌
check-schema-l10n ✅
check-l10n-js ✅
check-debt-ratchet ❌
check-types-e2e ✅
composer ✅ ✅ 109/109
npm ❌ ✅ 658/658
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌
Newman ⏭️
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-10-26 05:55 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde merged commit f79c41b into development Oct 26, 2026
43 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant