Repository navigation
Integrate dossiq batch b45: nc-vue 2.148.0 (24t2a), object views read the geo format - #4674
Merged
Merged
Conversation
viewsOf() read only type "geo", which is not a JSON Schema type. A schema
that declares {"type": "object", "format": "geo:point"} (or a geo: kind
as type) now offers Kaart, Tabel too.
Assisted-by: ClaudeCode:claude-opus-5-5
…ema 2.157.0 The access-purpose handler's accessPurpose page config needs schema 2.157.0; with it validate-manifest passes again on development. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
October 26, 2026 11:19
Contributor
Quality Report — ConductionNL/dossiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-debt-ratchet | ❌ | ||||
| check-types-e2e | ✅ | ||||
| composer | ✅ | ✅ 109/109 | |||
| npm | ❌ | ✅ 658/658 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-26 11:31 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dossiq batch b45:
accessPurposepage config, which the old schema refused.It builds on development be05332. DQ-L2's statusHistory fix turned out to be OpenRegister's (#4899, merged), so it is not in here.
Heads (merge order, --no-ff)
fix/object-views-read-geo-format5b6c079Integration changes
package.json, the lock andtests/schemas/app-manifest-v2.schema.jsonmove to 2.148.0 / schema 2.157.0.validate-manifestpasses again, and the seven vitest reds b44 named pass: landingViews, simpleCasePage, simpleListAndDashboard and validateManifestLag, 109/109.Verified locally
COMPOSER_PROCESS_TIMEOUT=0 composer check:strict, run alone: ALL CHECKS PASSED, exit 0. PHPUnit: 9911 tests, 0 errors, 0 failures.Prepared by a dossiq integration lane (AI-assisted, Claude Code); the coordinator merges.