Repository navigation
fix(example-sets): a required register behind its descriptor is imported again - #4897
Merged
Merged
Conversation
…ted again An example set skipped every required register already on the instance, so a schema fixed in the descriptor (public-space location type geo to object + format geo:point, #4895) never reached an instance that had installed the set. The set now re-imports a required register when its descriptor ships a newer version than the instance holds (RegisterDescriptorService::isBehind), and the public-space register and its four changed schemas move to 1.0.1. Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| test-l10n-parity | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| composer | ✅ | ✅ 173/173 | |||
| npm | ❌ | ✅ 648/648 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-26 11:12 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#4895 fixed
public_space_register.json(locationtype: geobecame{"type": "object", "format": "geo:point"}), but REFRESH-7b on :8080 still refused the 11 public-space objects. The stored schemas 1763, 1764, 1765 and 1767 kepttype: geo.The cause:
ExampleSetPrerequisites::ensureRegisters()skips every required register that is already on the instance. The fixed descriptor was therefore never imported again. The schema import itself does replace a schema at a higher version, or at the same version with different content.What
RegisterDescriptorService::isBehind(appId, slug, mock): true when the descriptor of that kind ships a newer register version than the instance holds. It uses the same "shipped vs installed" comparison as the inventory'sbehindstate.ExampleSetRegisters::isBehind()wraps it.ExampleSetPrerequisitesnow imports a required register again when it is behind, as well as when it is missing or its data was removed. The outcome readsimported.public_space_register.json: the register getsversion: 1.0.1(info 1.0.1). tree, street-light, play-equipment and road-section go to 1.0.1. market-pitch stays at 1.0.0, unchanged. On :8080 the next install sees the register behind and runs the mock import forced, which updates the four schemas.Tests
ExampleSetRequirementsTest::testARegisterBehindItsDescriptorIsImportedAgain: a present, behind register is imported again. It fails without the prerequisites change.RegisterDescriptorServiceTest::testARegisterIsBehindOnlyWhenItsDescriptorIsNewer: covers a newer mock, the same-version real descriptor, and an absent register.ImportHandlerSchemaVersioningTest::testAHigherVersionReplacesAStoredProperty: an import at 1.0.1 replaces a storedlocation: {type: geo}with{type: object, format: geo:point}.Verified
tests/Unit/Service/ExampleSetpass: 303 tests.check:strictwas not re-run, to keep the fix fast.Assisted-by: ClaudeCode:claude-opus-5-5