fix: validate proxy env vars and add .env.example - #306
Closed
MadalenaBastakou wants to merge 1 commit into
Closed
Conversation
Return clear 500 responses when required env vars are missing instead of opaque proxy failures. Add .env.example and update README quickstart. Co-authored-by: Madalena Bastakou <madalena.bastakou@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONDUIT_URLandMASTER_KEYin the Next.js API proxy before forwarding to Conduit Admin API, returning explicit 500 JSON errors when either is missing.apps/Conduit-UI/.env.exampledocumenting required and optional environment variables.Context
Login failures with opaque errors often trace to unset
CONDUIT_URL(Admin API base URL) orMASTER_KEY. This makes misconfiguration easier to diagnose.Test plan
POST /api/loginreturns 500 with clear error messageCONDUIT_URLandMASTER_KEY→ login succeeds against running Conduit instance